Code cleanup: coverage improvements and dead code removal#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocalizedErrorconformance toBuildErrorandSimulatorErrorfor proper error messages through generic catch blocksSwiftMutationTesting.run, extractdefaultLauncherhelperIncompatibleMutantExecutor,ProjectDetector,MutationRewriter,SchemataGenerator, andDiscoveryPipelinetry!withguard let try?inMutantExecutor.rewriteForIncompatiblekillEscapedChildreninternal for testabilityProcessRequestandProcessRunnerto reduce duplication across launchersProjectDetectorSPM test targets and testing framework detectionTestsdirectory from SwiftLint and Periphery validationType of Change
Invariants Checklist
xcodebuild build-for-testingruns exactly once for all schematizable mutantsschematizedContentnever contains the__swiftMutationTestingIDglobal declarationPipeline Impact
Which stages are affected?
Testing
ProcessLaunching— no realxcodebuild,xcrun simctl, orxcresulttoolFileHelpersfor any filesystem interaction (temp directories only)swift test)Coverage
Line coverage improved from 99.10% (42 missed) to 99.53% (22 missed). Key additions:
BuildErrorTests— errorDescription and equalitySimulatorErrorTests— errorDescription for all casesMutantExecutorCoverageTests— catch block, errorLines fallback, removingCases default transitionFallbackExecutorTests— SPM build success pathKillEscapedChildrenTests— process matching with real process spawningdefaultLaunchertests for xcode and spm project types