switch the default grid GroupBy from "None" to "Query Hash" and don't…#305
Merged
erikdarlingdata merged 1 commit intoerikdarlingdata:devfrom May 3, 2026
Conversation
… open the first line by default
1 task
erikdarlingdata
added a commit
that referenced
this pull request
May 3, 2026
PR #305 dropped the only caller of ExpandRowRecursive in FetchGroupedPlansAsync. Delete the now-unreachable method (only its self-recursion remained) plus stale Avalonia/SqlClient usings in the same file. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
|
Thanks for the contribution, @rferraton! 🙌 Defaulting to Query Hash grouping is a much better starting point — I find myself flipping to it every time too. Merged into Appreciate the screenshot and the careful test notes — keep 'em coming! |
erikdarlingdata
added a commit
to rferraton/PerformanceStudio
that referenced
this pull request
May 5, 2026
Resolves conflicts after dev's CRLF->LF normalization (erikdarlingdata#307) and the QueryStoreGridControl GroupBy default change (erikdarlingdata#305, erikdarlingdata#306). The only real conflict was leftover blank lines in QueryStoreGridControl.axaml.cs where erikdarlingdata#306 collapsed whitespace after removing ExpandRowRecursive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
QueryStoreGridControl.axaml:
• Changed GroupByBox default SelectedIndex from 0 (None) to 1 (Query Hash)
• Changed expand column IsVisible from False to True (since grouped mode is now the default)
QueryStoreGridControl.axaml.cs:
• Changed _groupByMode default from QueryStoreGroupBy.None to QueryHash
• Added ReorderColumnsForGroupBy() call before the initial fetch so columns are properly ordered on startup
• Removed the auto-expand of the first root row after grouped fetch (lines that called ExpandRowRecursive(first))
Which component(s) does this affect?
Motivation
I find more usefull to have a group by "query hash" by default, i always switch to that groupby so why not opening it by default directly ?
How was this tested?
Describe the testing you've done. Include:
Checklist
dotnet build -c Debug)dotnet test)