fix: remove shouldUnregister bug + CI pipeline restructure#111
Merged
Conversation
shouldUnregister: true stripped conditionally-rendered field values (duration, extendedBiddingTriggerWindow, extendedBiddingExtension) from the form data when their inputs unmounted, causing Zod validation to fail silently — the "Create Draft" button appeared to do nothing.
Three structural improvements to the CI pipeline: 1. Build/test separation: the Build job compiles once and uploads the workspace as an artifact; the 10 test matrix entries download it and run with --no-build, eliminating 10 redundant full builds. 2. Test matrix display fix: the matrix uses if: always() so GitHub always expands it, showing proper "Test — Contracts" etc. names even on frontend-only PRs. A gate step prevents actual execution when there are no code changes or the build did not succeed. 3. Frontend parallelism: the sequential frontend job is replaced by a 5-entry matrix (shared, bidder, ops, seller, e2e) so all SPA builds and tests run in parallel instead of sequentially.
erikshafer
changed the title
tar -czf dotnet-build.tar.gz . creates the archive inside the directory being archived, causing "file changed as we read it" (exit code 1). Writing to /tmp first avoids the self-reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fix:
shouldUnregister: truefrom theuseForm()call inCreateListingPage.tsxCI restructure:
--no-build, eliminating 10 redundant full buildsif: always()with an internal gate step so GitHub always expands the matrix, showing proper names ("Test — Contracts", "Test — Auctions", etc.) even on frontend-only PRs — fixes the${{ matrix.name }}raw template displayTest plan