chore(ci): CI audit — completeness verified, two low-risk cleanups#114
Merged
Conversation
The project uses .slnx; no .sln file exists, so the **/*.sln glob in the code path filter was dead weight. Removing it avoids the implication that a future .sln file would correctly retrigger CI. Adds an inline M8-D2 comment to the e2e matrix entry explaining why Playwright tests are typecheck-only in CI (requires the full Aspire stack; intentional deferral per M8-D2). No behaviour change — completeness audit confirmed 10/10 backend and 5/5 frontend matrix entries match on-disk projects/workspace members.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Out-of-band CI sanity-check at M9 close (pre-M10). No milestone slice — lightweight chore PR.
Completeness audit — all green
.Tests.csprojshared,bidder,ops,seller,e2e)Check-type mapping also verified:
sharedhas no test script (typecheck ✓);e2ehasplaywright testbut intentionally skipped per M8-D2 (typecheck ✓);bidder/ops/sellerall havevitest run(build-test ✓).Other checks: aggregator contract sound, concurrency correct, action versions on current major tags, artifact retention appropriate.
Changes applied
**/*.slnfilter — project uses.slnx; no.slnon disk. Glob never matched, but implied a file type that doesn't exist.e2etypecheck entry — inline comment referencing M8-D2 so future readers know the decision is intentional, not an oversight.No behaviour change. The CI pipeline's
ci.ymlis included in bothcode:andfrontend:path globs, so this PR's checks exercise the full build + test + frontend pipeline.Recommendations (not applied — not low-risk)
npm ciinstall job: Single install → artifact upload → 5 parallel downloads instead ofnpm ci ×5. Reduces install wall-clock time but restructures job graph.actions/checkout@<sha> # v4.x.xpattern for supply-chain hardening. Aesthetically noisy; out of scope for this audit.