fix(ctx): use okf:none marker for type-less imports to avoid collision#439
Merged
Conversation
The missing-type marker was okf:untyped, but a real OKF type literally named "Untyped" slugs to the same okf:untyped tag — so a present-but- named type and a genuinely type-less doc became indistinguishable, defeating the audit (`ctx list --tag` could no longer isolate stray non-concept .md files). Changed the marker to okf:none, which is not a plausible OKF concept type and stays unambiguous. Follow-up to #435 (which introduced the okf:untyped tag). - OkfCtxMapper: push okf:none for missing/empty/unusable type; docstring explains why none over untyped - new test asserts a real type "Untyped" tags okf:untyped and does NOT collide with the okf:none gap marker - help / docs/verbs.md / AGENT.md updated - changelog fragment renamed and given the collision rationale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#435 introduced the
okf:untypedtag to mark type-less docs onctx importso a stray non-concept.mdis auditable viactx list --tag okf:untyped. But the marker collides: a real OKF type literally namedUntypedslugs tookf:untypedtoo. A present-but-named type and a genuinely type-less doc become indistinguishable, defeating the audit.Fix
Marker changed to
okf:none— not a plausible OKF concept type, so it stays unambiguous. A realUntypedtype still tagsokf:untyped(correct provenance) and no longer shadows the gap marker.Changes
OkfCtxMapper.ts— pushokf:nonefor missing/empty/unusable type; docstring explainsnoneoveruntyped."Untyped"tagsokf:untypedand does NOT collide with theokf:nonegap marker.interface/index.tshelp,docs/verbs.md,AGENT.mdupdated.untyped-tag->none-marker) with the collision rationale.Tests
npm run test:passages346/346,npm run test:domain145/145 green.Follow-up to #435.