This repository was archived by the owner on Jul 17, 2022. It is now read-only.
Fix deprecation warning "The DefaultSourceDirectorySet constructor has been deprecated"#53
Open
robinverduijn wants to merge 5 commits intoeriwen:masterfrom
Conversation
robinverduijn
force-pushed
the
bugfix/deprecated-DefaultSourceDirectorySet-constructor
branch
from
ce52205 to
1e975be
Compare
|
@eriwen This is a import fix. |
resolve only resolvable configurations eriwen/gradle-js-plugin@d2e7e3b
…s been deprecated`. - Fixed by using the ObjectFactory service to create the source directory set This fixes the following deprecation warning seen in any projects that apply the gradle-css-plugin: ``` The DefaultSourceDirectorySet constructor has been deprecated. This is scheduled to be removed in Gradle 6.0. Please use the ObjectFactory service to create instances of SourceDirectorySet instead. ```
robinverduijn
force-pushed
the
bugfix/deprecated-DefaultSourceDirectorySet-constructor
branch
from
1e975be to
a52f13f
Compare
Author
It looks like by now, the changes from #52 should no longer be necessary as 9fe88d7 has dropped that class entirely. I have rebased my branch to pull in the latest I also pushed a change to fix the Travis CI build by updating the build container to |
robinverduijn
force-pushed
the
bugfix/deprecated-DefaultSourceDirectorySet-constructor
branch
from
f13e98c to
20b86ae
Compare
Author
|
@eriwen any concerns with this pull request? Could it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix deprecation warning
The DefaultSourceDirectorySet constructor has been deprecated.This fixes the following deprecation warning seen in any projects that apply the gradle-css-plugin:
There is an additional Gradle deprecation warning in this project, but that already has a PR open for it at #52 so I am not duplicating those changes here.