stdlib: Fix return value of zip:zip_get/2#11313
Open
dmitrivereshchagin wants to merge 1 commit into
Open
Conversation
Contributor
CT Test Results 2 files 100 suites 1h 6m 9s ⏱️ Results for commit e8a733e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
dmitrivereshchagin
force-pushed
the
stdlib/fix-zip-get-2
branch
from
1134a5d to
230046c
Compare
garazdawi
reviewed
Jul 1, 2026
| case get_z_file(In1, Z, Input, Output, [], fun silent/1, | ||
| CWD, ZFile, fun all/1, false, ExtraOpts) of | ||
| {file, R, _In2} -> {ok, R}; | ||
| {file, R, _In2} -> {ok, Output(flush, R)}; |
Member
There was a problem hiding this comment.
Suggested change
| {file, R, _In2} -> {ok, Output(flush, R)}; | |
| {file, R, _In2} -> {ok, Output(flush, R)}; |
When a file is extracted to a directory, the function returns a map
instead of a file name:
1> {ok, {_, B}} = zip:zip("", [{"F", ~""}], [memory]), ok.
ok
2> {ok, H} = zip:zip_open(B, [{cwd, "/tmp"}]), zip:zip_get("F", H).
{ok,#{flush => [],name => "/tmp/F"}}
dmitrivereshchagin
force-pushed
the
stdlib/fix-zip-get-2
branch
from
230046c to
e8a733e
Compare
garazdawi
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a file is extracted to a directory, the function returns a map instead of a file name: