ssh: Fix kex_strict_violation test race on debug builds#11314
Open
u3s wants to merge 2 commits into
Open
Conversation
The "duplicated ssh_msg_kexdh_init" sub-flow expected disconnect
immediately after kexdh_reply, but the server sends newkeys as part
of normal first-kexdh_init processing before it detects the duplicate
in {new_keys,server,init} state. On debug/lock-counting builds the
timing makes newkeys (or tcp_closed) arrive before disconnect.
Accept any of newkeys, disconnect, or tcp_closed after kexdh_reply.
The actual violation assertion is already verified through
event_logged(server, Events, "KEX strict violation") in
kex_strict_helper/3.
Contributor
CT Test Results 2 files 29 suites 29m 26s ⏱️ Results for commit 0a768d3. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Mikaka27
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "duplicated ssh_msg_kexdh_init" sub-flow expected disconnect immediately after kexdh_reply, but the server sends newkeys as part of normal first-kexdh_init processing before it detects the duplicate in {new_keys,server,init} state. On debug/lock-counting builds the timing makes newkeys (or tcp_closed) arrive before disconnect.
Accept any of newkeys, disconnect, or tcp_closed after kexdh_reply. The actual violation assertion is already verified through event_logged(server, Events, "KEX strict violation") in kex_strict_helper/3.