ssh test: Fix flaky interrupted_send race condition#11318
Open
u3s wants to merge 1 commit into
Open
Conversation
u3s
added
team:PS
Contributor
CT Test Results 2 files 29 suites 28m 53s ⏱️ Results for commit 8248e88. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
The interrupted_send test calls ssh:close/1 after the listener
collects its expected echo data, while the sender is still pushing
the remaining 6 MB. The connection teardown can race with the
ongoing send, causing {error, closed} instead of ok.
Accept both outcomes since the test's purpose is to verify the
listener received correct data, not that the full send completes.
u3s
force-pushed
the
kuba/ssh/fix_flaky_ssh_connection_test
branch
from
92921e8 to
8248e88
Compare
Mikaka27
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interrupted_send test calls ssh:close/1 after the listener collects its expected echo data, while the sender is still pushing the remaining 6 MB. The connection teardown can race with the ongoing send, causing {error, closed} instead of ok.
Accept both outcomes since the test's purpose is to verify the listener received correct data, not that the full send completes.