dialyzer: fix unmatched return warning tag

[bchassoul]

Fixes #11320

Dialyzer currently returns the misspelled warning tag
warn_umatched_return for unmatched-return warnings from
dialyzer:run/1.

This changes the tag to warn_unmatched_return.

The warning option (unmatched_returns) and the warning payload
(unmatched_return) are already spelled correctly, so this only
affects the warning tag returned in the raw warning tuple.

This also adds a test that checks the raw warning tuple returned by
dialyzer:run/1, since the existing unmatched-return coverage mainly
checks formatted warning text.

[CLAassistant]

All committers have signed the CLA.

[github-actions]

CT Test Results

  2 files   42 suites   16m 9s ⏱️
485 tests 481 ✅ 4 💤 0 ❌
573 runs  569 ✅ 4 💤 0 ❌

Results for commit 3c16044.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• No Windows Installer found

// Erlang/OTP Github Action Bot

[lucioleKi]

Thank you for the contribution. You can add the following license to abstract_SUITE.erl to suppress the warning. Please also try to fix the test case failure. I haven't looked closely. Does the test case succeed for you locally?

%%
%% %CopyrightBegin%
%%
%% SPDX-License-Identifier: Apache-2.0
%%
%% Copyright Ericsson AB 2016-2026. All Rights Reserved.
%%
%% Licensed under the Apache License, Version 2.0 (the "License");
%% you may not use this file except in compliance with the License.
%% You may obtain a copy of the License at
%%
%%     http://www.apache.org/licenses/LICENSE-2.0
%%
%% Unless required by applicable law or agreed to in writing, software
%% distributed under the License is distributed on an "AS IS" BASIS,
%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
%% See the License for the specific language governing permissions and
%% limitations under the License.
%%
%% %CopyrightEnd%
%%

[bchassoul]

Oh no, I think I committed an older version of the test 😞
It should be fixed now, and it passes locally:

TEST INFO: 1 test(s), 1 case(s) in 1 suite(s)

Testing tests.dialyzer_test.abstract_SUITE.unmatched_return_tag: Starting test, 1 test cases
Testing tests.dialyzer_test.abstract_SUITE.unmatched_return_tag: TEST COMPLETE, 1 ok, 0 failed of 1 test cases

[lucioleKi]

Thanks for the fix. Hopefully we only need to fix the license header in this file, and then everything would work :)

[lucioleKi]

Suggested change

	%%%
	%%% %CopyrightBegin%
	%%%
	%%% SPDX-License-Identifier: Apache-2.0
	%%%
	%%% Copyright 2004-2010 held by the authors. All Rights Reserved.
	%%% Copyright Ericsson AB 2009-2026. All Rights Reserved.
	%%%

[lucioleKi]

Suggested change

	%%% limitations under the License.
	%%%
	%%% %CopyrightEnd%
	%%%