michal/crypto/fix-aead-cipher-key-buffer-overread/OTP-20244#11337
Open
Mikaka27 wants to merge 1 commit into
Open
michal/crypto/fix-aead-cipher-key-buffer-overread/OTP-20244#11337Mikaka27 wants to merge 1 commit into
Mikaka27 wants to merge 1 commit into
Conversation
Contributor
CT Test Results 2 files 14 suites 5m 44s ⏱️ Results for commit 9852099. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Mikaka27
requested review from
Whaileee and
garazdawi
and removed request for
Whaileee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents chacha20-1305 aead cipher encryption/decryption from accepting too long/short key size. For chacha20-1305 openssl reads fixed 32 bytes from the buffer passed by the user, even if the buffer is shorter in reality, triggering out of bounds read, and we had checks for that disabled.
In addition to that
EVP_CIPHER_CTX_set_key_lengthcalls were added for all aead ciphers, this might detect invalid key sizes set by the programmer in the source code, because this function will validate the key size even for fixed key size ciphers.Contains the fix from #11330 because added validation also causes an early exit, and destructor trying to free a garbage pointer.