Skip to content

erts: Add configure test for getauxval(3)#11339

Open
jhogberg wants to merge 1 commit into
erlang:maintfrom
jhogberg:john/erts/fix-cross-builds-auxv
Open

erts: Add configure test for getauxval(3)#11339
jhogberg wants to merge 1 commit into
erlang:maintfrom
jhogberg:john/erts/fix-cross-builds-auxv

Conversation

@jhogberg

@jhogberg jhogberg commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Adds configure test that was missing from #11249, breaking some cross-builds.

Copilot AI review requested due to automatic review settings July 6, 2026 08:14
@jhogberg jhogberg self-assigned this Jul 6, 2026
@jhogberg jhogberg added team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

CT Test Results

    3 files    136 suites   53m 29s ⏱️
1 682 tests 1 626 ✅ 56 💤 0 ❌
2 325 runs  2 251 ✅ 74 💤 0 ❌

Results for commit 858db8f.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a configure-time capability check for getauxval(3) and wires it into the JIT alternate signal-stack sizing logic, addressing cross-build failures introduced by #11249 when <sys/auxv.h> / getauxval aren’t available in the target sysroot.

Changes:

  • Gate sys_signal_stack.c’s <sys/auxv.h> include and getauxval(AT_MINSIGSTKSZ) usage behind HAVE_GETAUXVAL.
  • Add an Autoconf probe intended to detect getauxval availability and define HAVE_GETAUXVAL.
  • Update generated erts/configure and erts/config.h.in accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
erts/emulator/sys/unix/sys_signal_stack.c Uses HAVE_GETAUXVAL to conditionally include <sys/auxv.h> and size the alt signal stack via AT_MINSIGSTKSZ.
erts/configure.ac Adds a configure check intended to detect getauxval and define HAVE_GETAUXVAL.
erts/configure Regenerated configure script reflecting the new check.
erts/config.h.in Adds #undef HAVE_GETAUXVAL template for config header generation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread erts/configure.ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants