erts: Add configure test for getauxval(3)#11339
Conversation
CT Test Results 3 files 136 suites 53m 29s ⏱️ Results for commit 858db8f. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
There was a problem hiding this comment.
Pull request overview
Adds a configure-time capability check for getauxval(3) and wires it into the JIT alternate signal-stack sizing logic, addressing cross-build failures introduced by #11249 when <sys/auxv.h> / getauxval aren’t available in the target sysroot.
Changes:
- Gate
sys_signal_stack.c’s<sys/auxv.h>include andgetauxval(AT_MINSIGSTKSZ)usage behindHAVE_GETAUXVAL. - Add an Autoconf probe intended to detect
getauxvalavailability and defineHAVE_GETAUXVAL. - Update generated
erts/configureanderts/config.h.inaccordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| erts/emulator/sys/unix/sys_signal_stack.c | Uses HAVE_GETAUXVAL to conditionally include <sys/auxv.h> and size the alt signal stack via AT_MINSIGSTKSZ. |
| erts/configure.ac | Adds a configure check intended to detect getauxval and define HAVE_GETAUXVAL. |
| erts/configure | Regenerated configure script reflecting the new check. |
| erts/config.h.in | Adds #undef HAVE_GETAUXVAL template for config header generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds configure test that was missing from #11249, breaking some cross-builds.