ssl: Support ECDHE-PSK Chacha20-Poly1305#11345
Open
hjianbo wants to merge 1 commit into
Open
Conversation
The TLS_ECDHE_PSK_WITH_CHACHA20_POLY1305_SHA256 codepoint already exists and ssl already supports the required ecdhe_psk key exchange and chacha20_poly1305 AEAD cipher. Add the missing binary/map conversions and include the suite in the TLS 1.2 anonymous PSK list so it can be selected explicitly. Add a DTLS 1.2 PSK handshake regression test.
|
|
Contributor
CT Test ResultsTests are running... https://github.com/erlang/otp/actions/runs/28912401559 Results for commit f626b30 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for
TLS_ECDHE_PSK_WITH_CHACHA20_POLY1305_SHA256.The codepoint already exists, and OTP already supports the required
ecdhe_pskkey exchange andchacha20_poly1305AEAD cipher. The suite was only missing from the cipher suite map conversions and the TLS 1.2 anonymous PSK suite list.This came up from DTLS users whose devices commonly use this PSK cipher suite with forward secrecy.
This PR adds the missing entries and a focused DTLS 1.2 PSK handshake regression test.
The issue also affects OTP 28, so please consider backporting it to
maint-28.