sasl: tolerate dead processes during code_change#11346
Open
v0idpwn wants to merge 2 commits into
Open
Conversation
Contributor
CT Test Results 2 files 18 suites 7m 54s ⏱️ Results for commit c37a56c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
v0idpwn
force-pushed
the
fix/sasl-dead-proc
branch
from
26a7e48 to
f8b1a12
Compare
v0idpwn
changed the title
If a process exits between suspend and code_change, the release install would fail with a noproc exit. Since a dead process is not running old code, this is safe to ignore.
v0idpwn
force-pushed
the
fix/sasl-dead-proc
branch
from
f8b1a12 to
a2d70d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a process exits between suspend and code_change, the release install currently fails with a noproc exit. Since a dead process is not running old code, the process death is safe to ignore. This is consistent with the
sys:suspendbehaviour which also ignores dying processes.This patch is coming from a situation I had on a hot code deployment, where an expected sub-tree shut down caused the whole relup to fail. Sample failure:
Failing code_change still fail the relup, as it goes through the error tuple path.