compiler: Miscellaneous fixes#11347
Open
lucioleKi wants to merge 5 commits into
Open
Conversation
Contributor
CT Test Results 3 files 420 suites 1h 13m 53s ⏱️ Results for commit 99a724d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Fix an unsafe destructive update when the updated record is the result of BIF `min/2` or `max/2`.
Previously, if the type pass found out `X` is a number, `X div 1` would become `X`. This is incorrect when `X` is a float. Drop this optimization for div when the type pass cannot ensure that `X` is an integer.
…ing/1` Previously, a badly-formed `-deprecated_type` or `-deprecated_callback` could be allowed by `erl_lint.erl`, and then crashes in `beam_docs:info_string/1`. Add extra checks to avoid this crash.
lucioleKi
force-pushed
the
isabell/compiler/cs-fixes-1
branch
from
3fcda30 to
99a724d
Compare
lucioleKi
added
the
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details.