Skip to content

kernel: Publish code_server mode before registering #11354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bruckner wants to merge 1 commit into
base: maint
Choose a base branch
from
+10 −1
Open

kernel: Publish code_server mode before registering #11354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/kernel/src/code_server.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,16 @@ get_mode() ->
%% -----------------------------------------------------------

init(Ref, Parent, [Root,Mode]) ->
%% The mode must be readable as soon as the name resolves:
%% error_handler routes lazy loads through code:ensure_loaded/1
%% (which reads this term via get_mode/0) once
%% whereis(code_server) succeeds, and processes already running
%% during kernel start -- notably the logger kernel process --
%% can hit an undefined function while init/3 is still building
%% the code path. Publishing the term only after register/2 left
%% a window where such a load raised badarg, killing logger and
%% the whole boot (GH-11353).
persistent_term:put(?MODULE, Mode),
register(?MODULE, self()),
process_flag(trap_exit, true),

Expand Down Expand Up @@ -120,7 +130,6 @@ init(Ref, Parent, [Root,Mode]) ->
moddb = Db,
namedb = create_namedb(Path, Root)},

persistent_term:put(?MODULE, Mode),
Parent ! {Ref,{ok,self()}},
loop(State).

Expand Down