Skip to content

feat: enrich products with creator info#3

Open
parse wants to merge 9 commits intomainfrom
test/product-calls-user-service
Open

feat: enrich products with creator info#3
parse wants to merge 9 commits intomainfrom
test/product-calls-user-service

Conversation

@parse
Copy link
Contributor

@parse parse commented Mar 1, 2026

Adds a /products/:id/creator endpoint that fetches user info from the user service to show who created a product.

This introduces a new product_service → user_service dependency not currently declared in the architecture model.

Add endpoint that fetches user info from the user service
to show who created a product.
@erode-app
Copy link

erode-app bot commented Mar 1, 2026

Architectural Drift Analysis

Component: api_gateway (API Gateway)

Selected from 5 candidates
  • frontend (Web Frontend)
  • api_gateway (API Gateway)
  • user_service (User Service)
  • product_service (Product Service)
  • database (Database)

Status: ⚠️ Issues detected

🆕 New Components Detected

Component Kind Name
order_service service Order Service

These components were auto-detected from the PR and will be proposed for the architecture model.

Detected Issues (2)

  • [MEDIUM] A new dependency from product_service to user_service (to fetch creator info) was added, but this relationship is not currently declared in the architecture model.
    • Source: packages/product-service/src/index.ts
    • Recommendation: Update the architecture model to add a product_service -> user_service [https] relationship to reflect this dependency.
  • [LOW] A new service, order_service, has been introduced and communicates with product_service, but this component and its dependency are not documented in the architecture model.
    • Source: packages/order-service/src/index.ts
    • Recommendation: Add order_service to the model, and declare its relationship to product_service, reflecting the new service-to-service interaction.

How to Resolve:
Adjust the architecture model to:

  • Include missing relationships between components
  • Revise component boundaries if code has been relocated
  • Record intentional architectural changes

Suggested Model Changes

Add:

  • product_service -> user_service [https]
  • order_service (component)
  • order_service -> product_service [https]

Model Update Updated

A change request was updated to update the architecture model:
erode-app/playground-models-only#2

Overview

This PR introduces two sources of architectural drift: a new dependency from product_service to user_service (not yet modeled), and the creation of a new order_service component with cross-service calls. Amending the model to include these is recommended. The changes avoid high-impact violations, but the growing service mesh and new couplings require monitoring.

Analysis details
AI Provider openai
Quick model (Stages 1, 2) gpt-4.1-mini
Deep model (Stage 3) gpt-4.1

Automated by erode

@parse
Copy link
Contributor Author

parse commented Mar 2, 2026

/erode update-model

1 similar comment
@parse
Copy link
Contributor Author

parse commented Mar 2, 2026

/erode update-model

New order-service (port 3005) with GET/POST /orders endpoints.
POST /orders validates the product exists by calling product-service.
API gateway updated with proxy routes to order-service.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
erode-app bot added a commit to erode-app/playground-models-only that referenced this pull request Mar 2, 2026
@erode-app erode-app locked and limited conversation to collaborators Mar 3, 2026
@erode-app erode-app unlocked this conversation Mar 7, 2026
erode-app bot added a commit to erode-app/playground-models-only that referenced this pull request Mar 7, 2026
@erode-app erode-app locked and limited conversation to collaborators Mar 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant