test(stats): cover span_days, time bounds, and tie-breaking#41
Merged
Conversation
Three new tests for summarize() paths that were not exercised: - span_days and earliest/latest on a concrete non-empty log (2-day span) - single-event log: span_days == 0.0 and all length stats == 1 - _top_n_sorted tie-breaking: equal-count activities sort lexicographically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pm_bench/stats.pyhas three behaviors that existing tests intest_stats.pydo not exercise:span_days,earliest, andlatestare only tested on an empty log (where they are trivially 0 / None). No test confirms the calculation on a real log._top_n_sortedguarantees ties are broken lexicographically, but no test pins that contract.These gaps mean a regression in
summarize()could slip through CI undetected. This PR closes them with three targeted unit tests, no production-code changes.What
test_summarize_span_days_and_time_bounds: verifiesspan_days == 2.0andearliest/lateston the shared_events()fixture (a log that spans exactly 2 days).test_summarize_single_event_span_zero: single case, single event; span = 0.0, earliest = latest = the event timestamp, all length stats = 1.test_summarize_tie_breaking_is_lexicographic: in_events()both "a" and "b" appear 2 times, and "c"/"x" appear 1 time each; asserts the full ordering [("a",2), ("b",2), ("c",1), ("x",1)].Tests
pytest tests/test_stats.pySelf-merge gate
Generated by Claude Code