docs(inbound-email): document AttachmentDownloader across greenfield frameworks#7
Open
mpge wants to merge 1 commit intodocs/greenfield-inbound-emailfrom
Open
docs(inbound-email): document AttachmentDownloader across greenfield frameworks#7mpge wants to merge 1 commit intodocs/greenfield-inbound-emailfrom
mpge wants to merge 1 commit intodocs/greenfield-inbound-emailfrom
Conversation
…frameworks
Every greenfield framework now ships a reference AttachmentDownloader
for persisting the provider-hosted URLs in
pending_attachment_downloads (Mailgun's larger files). Before this
round host maintainers had to write their own download + persist logic.
Each of the 5 framework pages gains a "Downloading provider-hosted
attachments" section with:
- Ready-to-paste snippet constructing the downloader with the
reference LocalFile storage backend.
- Size-cap + Mailgun basic-auth wiring.
- downloadAll partial-failure semantics.
- Typed too-large error per framework.
- Path-traversal sanitization guarantees.
- Escape hatch: how to swap in S3 / GCS / Azure by implementing
the storage interface.
Drive-by: fix Spring page's response example (outcome was uppercased
"CREATED_NEW"; actual response is lowercased "created_new" via
Enum.name().toLowerCase()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every greenfield framework now ships a reference `AttachmentDownloader` for persisting the provider-hosted URLs in `pending_attachment_downloads` (Mailgun's larger files).
Before this round host maintainers had to write their own download + persist logic; this PR adds a "Downloading provider-hosted attachments" section to each of the 5 framework doc pages with:
Drive-by fix
Spring page's response example had `outcome: "CREATED_NEW"` (uppercased). Actual response is lowercased `"created_new"` via `Enum.name().toLowerCase()`. Corrected.
Stacked PR
Based on `docs/greenfield-inbound-email` (#6) so the 5 framework pages exist.