test(inbound): HTTP-level InboundEmailController tests (@WebMvcTest)#31
Open
mpge wants to merge 1 commit intofeat/inbound-email-orchestrationfrom
Open
test(inbound): HTTP-level InboundEmailController tests (@WebMvcTest)#31mpge wants to merge 1 commit intofeat/inbound-email-orchestrationfrom
mpge wants to merge 1 commit intofeat/inbound-email-orchestrationfrom
Conversation
Mirrors the Go (escalated-go#34) and .NET (escalated-dotnet#28)
patterns at the Spring Boot controller layer. Uses @WebMvcTest
to boot just the controller with a MockMvc client, MockBean'd
InboundEmailService, and the real PostmarkInboundParser imported
so payload parsing isn't mocked.
Nine cases cover:
- new-ticket happy path → outcome=created_new
- matched reply via canonical <ticket-55@...> In-Reply-To →
outcome=replied_to_existing + replyId
- SNS confirmation skip → outcome=skipped, null ticketId
- provider-hosted attachments surfaced in
pendingAttachmentDownloads[].downloadUrl
- missing/bad secret → 401 + service never called
- unknown/missing adapter → 400 + service never called
- adapter selection via X-Escalated-Adapter header (fallback
to query param)
Closes the HTTP-level coverage gap — the Spring controller was
already wired correctly via #29 but had no MockMvc tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the Go (escalated-go#34) and .NET (escalated-dotnet#28) patterns at the Spring Boot controller layer. Uses `@WebMvcTest` to boot just the controller with a MockMvc client, MockBean'd `InboundEmailService`, and the real `PostmarkInboundParser` imported so payload parsing isn't mocked.
What's tested
Nine cases:
Stacked PR
Based on `feat/inbound-email-orchestration` (#29) so the service + outcome enum are available. Merge order: #26 → #27 → #28 → #29 → this PR.
Test plan