Chore/fix version manifest - #1
Merged
Merged
Conversation
- Migrate pyproject.toml from [tool.poetry] to [project] (PEP 621) form - version = "0.0.0" placeholder; poetry-dynamic-versioning overwrites at build time - Add pre-commit hooks: trailing-whitespace, end-of-file-fixer, check-toml, check-yaml, ruff, ruff-format - Regenerate poetry.lock after pyproject restructure - Fix trailing whitespace and missing newlines in LICENSE, verify.yml, security.yml
- verify.yml, security.yml: install poetry before setup-python (fixes 'poetry not found' in cache lookup) - all workflows: checkout@v4 -> v5, setup-python@v5 -> v6 (fixes Node.js 20 deprecation warnings)
Contributor
There was a problem hiding this comment.
Pull request overview
Updates vstack’s versioning and release/tooling metadata so installed manifests and developer/CI workflows are aligned with a 1.0.1 bump.
Changes:
- Resolve
vstack.constants.VERSIONvia an exact semver git tag on HEAD (fallback to package metadata /"0.0.0"). - Bump skill/agent template versions (and related docs/manifests) from
1.0.0→1.0.1. - Expand repo tooling: add tox config + multi-Python test matrix, update Makefile/README, and extend pre-commit hooks.
Reviewed changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/vstack/constants.py |
Adds git-tag-based version resolution and fallback logic. |
tests/vstack/test_constants.py |
Adds unit tests for git-tag/version resolution behavior. |
tests/vstack/test_main.py |
Adds dispatch/flag-resolution coverage (including uninstall path). |
pyproject.toml |
Migrates metadata to [project], adds tox config, tightens coverage gate. |
poetry.lock |
Updates lockfile to include tox-related dependencies. |
Makefile |
Adds tox-based testing targets and adjusts test semantics. |
README.md |
Documents Python support bounds and tox/pyenv local workflows. |
.github/workflows/qa.yml |
Adds a Python-version test matrix job. |
.pre-commit-config.yaml |
Adds common hygiene hooks + ruff hooks. |
src/vstack/cli/manifest.py |
Updates manifest format example version. |
src/vstack/_templates/**/config.yaml |
Bumps template versions to 1.0.1. |
docs/design/{agents,design,skills}.md |
Updates embedded config examples to 1.0.1. |
CHANGELOG.md |
Adds 1.0.1 release notes. |
.python-version |
Adds pinned multi-version pyenv order. |
.github/vstack.json |
Updates installed manifest content to reflect regenerated artifacts. |
LICENSE |
Removes trailing whitespace/newline artifact. |
.github/workflows/{verify,security}.yml |
No functional change (format-only). |
Avoids coupling to .venv/bin/python. Uses the active interpreter, which is the Poetry-managed env in CI and .venv locally.
Ensures poetry install creates .venv in-project so all make targets that reference $(VENV_PYTHON) work without explicit activation.
_head_semver_tag() now only runs git when inside the vstack source checkout (detected via _vstack_repo_root()). Prevents VERSION from incorrectly resolving to a HEAD tag from the user's working repo when vstack is installed as a tool and invoked from another git project.
Prefer .venv/bin/python when present; otherwise use poetry run python and finally PYTHON. Prevents CI failures when tox is not on runner python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.