Skip to content

fix(ci): align dynamic version config for 1.3.5 release - #20

Merged
eschaar merged 1 commit into
mainfrom
fix/release-versioning-1-3-5
Apr 22, 2026
Merged

fix(ci): align dynamic version config for 1.3.5 release#20
eschaar merged 1 commit into
mainfrom
fix/release-versioning-1-3-5

Conversation

@eschaar

@eschaar eschaar commented Apr 22, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes dynamic version resolution for release builds by aligning pyproject.toml with poetry-dynamic-versioning expectations and moves the related release notes to 1.3.5 in CHANGELOG.md.

  • Replaced project.version = "0.0.0" with project.dynamic = ["version"].
  • Added tool.poetry.version = "0.0.0" as the placeholder version source for Poetry.
  • Removed unsupported tool.poetry-dynamic-versioning.fallback-version.
  • Updated changelog entries so these fixes are tracked under 1.3.5 instead of 1.3.4.

Why

Release builds were resolving to 0.0.0 despite dynamic versioning being enabled.
The project metadata layout was not aligned with how poetry-dynamic-versioning injects the computed tag version in this setup.

Version impact

  • None
  • Patch
  • Minor
  • Major

Copilot AI review requested due to automatic review settings April 22, 2026 19:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns packaging metadata with poetry-dynamic-versioning so release builds resolve the tag-derived version correctly, and records the fix under the 1.3.5 changelog entry.

Changes:

  • Switched PEP 621 metadata to project.dynamic = ["version"] and moved the placeholder version to tool.poetry.version.
  • Removed tool.poetry-dynamic-versioning.fallback-version from pyproject.toml.
  • Added a new 1.3.5 section in CHANGELOG.md to track these fixes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Updates version metadata layout to match poetry-dynamic-versioning injection behavior and removes an unsupported config key.
CHANGELOG.md Adds release notes for 1.3.5 describing the dynamic versioning configuration fixes.

Comment thread pyproject.toml
@eschaar
eschaar force-pushed the fix/release-versioning-1-3-5 branch from 6de7ebf to 66d13c5 Compare April 22, 2026 19:23
@eschaar eschaar self-assigned this Apr 22, 2026
@eschaar
eschaar merged commit 743efec into main Apr 22, 2026
12 checks passed
@eschaar
eschaar deleted the fix/release-versioning-1-3-5 branch April 22, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants