fix(ci): align dynamic version config for 1.3.5 release - #20
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns packaging metadata with poetry-dynamic-versioning so release builds resolve the tag-derived version correctly, and records the fix under the 1.3.5 changelog entry.
Changes:
- Switched PEP 621 metadata to
project.dynamic = ["version"]and moved the placeholder version totool.poetry.version. - Removed
tool.poetry-dynamic-versioning.fallback-versionfrompyproject.toml. - Added a new
1.3.5section inCHANGELOG.mdto track these fixes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Updates version metadata layout to match poetry-dynamic-versioning injection behavior and removes an unsupported config key. |
| CHANGELOG.md | Adds release notes for 1.3.5 describing the dynamic versioning configuration fixes. |
eschaar
force-pushed
the
fix/release-versioning-1-3-5
branch
from
April 22, 2026 19:23
6de7ebf to
66d13c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dynamic version resolution for release builds by aligning
pyproject.tomlwithpoetry-dynamic-versioningexpectations and moves the related release notes to1.3.5inCHANGELOG.md.project.version = "0.0.0"withproject.dynamic = ["version"].tool.poetry.version = "0.0.0"as the placeholder version source for Poetry.tool.poetry-dynamic-versioning.fallback-version.1.3.5instead of1.3.4.Why
Release builds were resolving to
0.0.0despite dynamic versioning being enabled.The project metadata layout was not aligned with how
poetry-dynamic-versioninginjects the computed tag version in this setup.Version impact