Feat/extended - #39
Merged
Merged
Conversation
…fety, release-readiness prompts
…18 skill-agent boundary
…ess prompt versions to 0.1.1
Update template config versions using file modified dates and per-day sequence. Document the revision-token policy in existing design docs and ADR-014. Add install comparator test coverage for date-based revisions and adjust service fixture.
Align all role templates with required section order and add completion/artifact sections. Add tests for canonical heading order and handoff target validity. Bump agent template revisions to YYYYMMDDNNN.
Add a STRIDE-first threat-model skill with optional DREAD prioritization and PASTA depth guidance. Wire threat-model into canonical skill lists, docs, and role templates where it is most likely used. Remove decorative ruler lines across skill templates and document token-efficiency guidance in skills documentation.
Introduce GitHub-specific release skill and wire it into canonical lists, docs, and release agent usage. Harden release flow with immutable tag checks, prerelease/latest handling, generated-notes fallback, and optional checksum upload guidance.
Introduce a Conventional Commit preparation skill with intent-based type/scope selection and message-content validation. Register the skill in canonical lists, docs, and engineer/release agent skill usage.
- cicd: pin TruffleHog to @V3 (was @main, supply-chain risk); add workflow_dispatch trigger; add concurrency cancellation group; add timeout-minutes and permissions: contents: read on CI job; add actions/cache step for Python, Node, and Go; update review checklist - explore: fix invalid find --exclude-dir flag (grep-only option); use -not -path '*/node_modules/*' and '*/venv/*' instead - migrate: same find --exclude-dir fix in Step 0 discovery command - security: add --exclude-dir=vendor to all grep commands in A01 endpoint scan, A02, A03, A05, A07, A09, and A10 for consistency - pr: add gh auth status pre-flight check; detect existing open PR before creating a new one; detect PR template; document --body-file for long bodies and --draft for in-progress PRs
…o agent mappings
- Add 9 new skills to docs/design/skills.md table (gh-issues, codeql,
dependabot, secret-scan, gdpr, terraform, terragrunt, cloudformation, aws-cli)
- Add terraform and terragrunt instructions to docs/design/instructions.md table
- Update docs/design/agents.md last-updated date
- Add new skills to 'skills you use' in all 5 role agent templates:
engineer: +dependabot, +secret-scan, +gdpr, +terraform, +terragrunt,
+cloudformation, +aws-cli
tester: +codeql, +secret-scan, +dependabot, +gdpr, +aws-cli
architect: +gdpr
release: +gh-issues
product: +gh-issues
- Regenerate .github/agents/ from updated templates
- gdpr: remove Step 11 anti-patterns table (duplication of Steps 1-10 and PR checklist) - dependabot: compact versioning strategy to prose; trim cooldown; remove deprecated PR comment entries - codeql: merge Step 5 paths-ignore into Step 4 monorepo config; compact CLI section (Step 7 → Step 6) - terragrunt: compact Step 7 _envcommon (remove redundant unit-load pattern already shown in Step 4) - gh-issues: merge Step 5 comment into Step 4 update; compact Output section - cloudformation: compact Step 3 naming rules to inline note; collapse cfn-lint checks to single line - terraform: compact Step 0 detect commands; trim Step 10 state ops note No content removed that was not duplicated elsewhere. -75 lines total.
…fic skills and instructions Add a '## References' section with official documentation links to: - New skills (9): gh-issues, codeql, dependabot, secret-scan, gdpr, terraform, terragrunt, cloudformation, aws-cli - Existing skills (6): cicd, container, openapi, gh-release, security, dependency - New instructions (2): terraform, terragrunt Each references section includes a version-awareness note: 'Always use the official documentation for the exact version in use \u2014 options and syntax change between releases.' No skill logic or checklist items changed.
- add near-term candidates for code review, MCP-first GitHub tasks, and Spaces context - add governance candidates for content exclusion, MCP usage, Copilot Memory, usage-based billing, and admin observability - add VS Code customization starter pack candidate - add template overlays + selective install candidate for upstream + company source composition and type-based installs - update skill-count references from 27 to 39 for consistency
- add new skills: k8s, helm, rancher - add new instructions: k8s, helm, rancher - wire new skills into engineer and tester agent mappings - update canonical skill/instruction lists and tests - update design docs for skills and instructions - update roadmap skill count and candidate coverage - regenerate .github artifacts and manifest via vstack install
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands vstack’s template-driven catalog by adding many new skills, instructions, prompts, and agent wiring updates, while also shifting artifact revisioning from SemVer-style strings to date-based ordering tokens. It fits the codebase by extending the install-time generated .github/ workflow assets and updating docs/tests to reflect the larger capability set.
Changes:
- Added new source templates and generated artifacts for additional skills, instructions, and prompts, including Kubernetes/Helm/Rancher support.
- Updated role agent templates, registries, and tests to cover new capabilities and canonical structure expectations.
- Switched many template/config artifact versions to
YYYYMMDDNNN-style revision tokens and refreshed related documentation.
Reviewed changes
Copilot reviewed 214 out of 214 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
tests/vstack/cli/test_service.py |
Updates install/version comparison fixture to use numeric revision tokens. |
tests/vstack/cli/test_install.py |
Extends _version_gt tests for date-style revisions. |
tests/vstack/cli/test_constants.py |
Expands expected canonical skill registry coverage. |
tests/vstack/agents/test_template_structure.py |
Adds canonical heading-order checks for role agent templates. |
tests/vstack/agents/test_role_wiring.py |
Adds handoff target validation for agent configs. |
src/vstack/cli/install.py |
Documents revision comparison as token-based, not SemVer-only. |
src/vstack/cli/constants.py |
Expands canonical skill/instruction/prompt registries. |
src/vstack/_templates/skills/vision/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/vision/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/verify/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/verify/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/threat-model/config.yaml |
Adds new threat-model skill metadata. |
src/vstack/_templates/skills/terragrunt/config.yaml |
Adds new terragrunt skill metadata. |
src/vstack/_templates/skills/terraform/config.yaml |
Adds new terraform skill metadata. |
src/vstack/_templates/skills/security/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/secret-scan/config.yaml |
Adds new secret-scan skill metadata. |
src/vstack/_templates/skills/requirements/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/requirements/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/release-notes/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/refactor/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/refactor/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/rancher/template.md |
Adds new Rancher skill procedure. |
src/vstack/_templates/skills/rancher/config.yaml |
Adds Rancher skill metadata. |
src/vstack/_templates/skills/pr/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/performance/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/performance/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/openapi/template.md |
Adds references and removes separators. |
src/vstack/_templates/skills/openapi/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/onboard/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/onboard/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/migrate/template.md |
Fixes find command usage and removes separators. |
src/vstack/_templates/skills/migrate/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/k8s/template.md |
Adds new Kubernetes skill procedure. |
src/vstack/_templates/skills/k8s/config.yaml |
Adds Kubernetes skill metadata. |
src/vstack/_templates/skills/inspect/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/inspect/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/incident/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/incident/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/helm/template.md |
Adds new Helm skill procedure. |
src/vstack/_templates/skills/helm/config.yaml |
Adds Helm skill metadata. |
src/vstack/_templates/skills/guardrails/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/guardrails/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/gh-release/config.yaml |
Adds new gh-release skill metadata. |
src/vstack/_templates/skills/gh-issues/config.yaml |
Adds new gh-issues skill metadata. |
src/vstack/_templates/skills/gdpr/config.yaml |
Adds new GDPR skill metadata. |
src/vstack/_templates/skills/explore/template.md |
Fixes find usage and removes separators. |
src/vstack/_templates/skills/explore/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/docs/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/docs/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/design/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/design/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/dependency/template.md |
Adds references and removes separators. |
src/vstack/_templates/skills/dependency/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/dependabot/config.yaml |
Adds new Dependabot skill metadata. |
src/vstack/_templates/skills/debug/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/debug/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/conventional-commit/template.md |
Adds new conventional-commit skill procedure. |
src/vstack/_templates/skills/conventional-commit/config.yaml |
Adds conventional-commit skill metadata. |
src/vstack/_templates/skills/container/template.md |
Adds references and removes trailing separator. |
src/vstack/_templates/skills/container/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/consult/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/consult/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/concise/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/concise/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/codeql/config.yaml |
Adds new CodeQL skill metadata. |
src/vstack/_templates/skills/code-review/template.md |
Removes trailing separator from skill template. |
src/vstack/_templates/skills/code-review/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/cloudformation/config.yaml |
Adds new CloudFormation skill metadata. |
src/vstack/_templates/skills/cicd/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/aws-cli/config.yaml |
Adds new AWS CLI skill metadata. |
src/vstack/_templates/skills/architecture/template.md |
Removes trailing separator from skill template. |
src/vstack/_templates/skills/architecture/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/analyse/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/analyse/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/skills/adr/template.md |
Removes separator lines from skill template. |
src/vstack/_templates/skills/adr/config.yaml |
Moves skill revision to date-based token. |
src/vstack/_templates/prompts/release-readiness/template.md |
Adds new release-readiness prompt template. |
src/vstack/_templates/prompts/release-readiness/config.yaml |
Adds release-readiness prompt metadata. |
src/vstack/_templates/prompts/migration-safety/template.md |
Adds new migration-safety prompt template. |
src/vstack/_templates/prompts/migration-safety/config.yaml |
Adds migration-safety prompt metadata. |
src/vstack/_templates/prompts/incident-timeline/template.md |
Adds new incident-timeline prompt template. |
src/vstack/_templates/prompts/incident-timeline/config.yaml |
Adds incident-timeline prompt metadata. |
src/vstack/_templates/prompts/dependency-audit/template.md |
Adds new dependency-audit prompt template. |
src/vstack/_templates/prompts/dependency-audit/config.yaml |
Adds dependency-audit prompt metadata. |
src/vstack/_templates/prompts/code-review/template.md |
Expands code-review prompt focus areas. |
src/vstack/_templates/prompts/code-review/config.yaml |
Moves prompt revision to date-based token. |
src/vstack/_templates/prompts/architecture-risk/template.md |
Adds new architecture-risk prompt template. |
src/vstack/_templates/prompts/architecture-risk/config.yaml |
Adds architecture-risk prompt metadata. |
src/vstack/_templates/prompts/api-design-review/template.md |
Adds new api-design-review prompt template. |
src/vstack/_templates/prompts/api-design-review/config.yaml |
Adds api-design-review prompt metadata. |
src/vstack/_templates/instructions/typescript/template.md |
Adds new TypeScript instruction template. |
src/vstack/_templates/instructions/typescript/config.yaml |
Adds TypeScript instruction metadata. |
src/vstack/_templates/instructions/testing/template.md |
Adds new testing instruction template. |
src/vstack/_templates/instructions/testing/config.yaml |
Adds testing instruction metadata. |
src/vstack/_templates/instructions/terragrunt/template.md |
Adds new Terragrunt instruction template. |
src/vstack/_templates/instructions/terragrunt/config.yaml |
Adds Terragrunt instruction metadata. |
src/vstack/_templates/instructions/terraform/template.md |
Adds new Terraform instruction template. |
src/vstack/_templates/instructions/terraform/config.yaml |
Adds Terraform instruction metadata. |
src/vstack/_templates/instructions/security/template.md |
Adds new security instruction template. |
src/vstack/_templates/instructions/security/config.yaml |
Adds security instruction metadata. |
src/vstack/_templates/instructions/rancher/template.md |
Adds new Rancher instruction template. |
src/vstack/_templates/instructions/rancher/config.yaml |
Adds Rancher instruction metadata. |
src/vstack/_templates/instructions/python/config.yaml |
Moves instruction revision to date-based token. |
src/vstack/_templates/instructions/markdown/template.md |
Adds new Markdown instruction template. |
src/vstack/_templates/instructions/markdown/config.yaml |
Adds Markdown instruction metadata. |
src/vstack/_templates/instructions/k8s/template.md |
Adds new Kubernetes instruction template. |
src/vstack/_templates/instructions/k8s/config.yaml |
Adds Kubernetes instruction metadata. |
src/vstack/_templates/instructions/java/template.md |
Adds new Java instruction template. |
src/vstack/_templates/instructions/java/config.yaml |
Adds Java instruction metadata. |
src/vstack/_templates/instructions/helm/template.md |
Adds new Helm instruction template. |
src/vstack/_templates/instructions/helm/config.yaml |
Adds Helm instruction metadata. |
src/vstack/_templates/instructions/git/config.yaml |
Moves instruction revision to date-based token. |
src/vstack/_templates/agents/tester/template.md |
Restructures tester agent sections and adds skill mappings. |
src/vstack/_templates/agents/tester/config.yaml |
Moves tester agent revision to date-based token. |
src/vstack/_templates/agents/release/template.md |
Restructures release agent sections and adds skill mappings. |
src/vstack/_templates/agents/release/config.yaml |
Moves release agent revision to date-based token. |
src/vstack/_templates/agents/product/template.md |
Restructures product agent sections and adds skill mappings. |
src/vstack/_templates/agents/product/config.yaml |
Moves product agent revision to date-based token. |
src/vstack/_templates/agents/engineer/config.yaml |
Moves engineer agent revision to date-based token. |
src/vstack/_templates/agents/designer/template.md |
Restructures designer agent sections. |
src/vstack/_templates/agents/designer/config.yaml |
Moves designer agent revision to date-based token. |
src/vstack/_templates/agents/architect/template.md |
Restructures architect agent sections and adds skill mappings. |
src/vstack/_templates/agents/architect/config.yaml |
Moves architect agent revision to date-based token. |
docs/design/instructions.md |
Updates instruction catalog documentation. |
docs/design/design.md |
Documents artifact version tokens as revision ordering values. |
docs/architecture/adr/018-skill-genericity-boundary.md |
Adds new ADR about skill vs agent boundary. |
docs/architecture/adr/014-manifest-schema-versioning.md |
Clarifies artifact-entry version token policy. |
README.md |
Documents prompt catalog usage and template editing example. |
.github/skills/vision/SKILL.md |
Regenerated vision skill artifact. |
.github/skills/verify/SKILL.md |
Regenerated verify skill artifact. |
.github/skills/requirements/SKILL.md |
Regenerated requirements skill artifact. |
.github/skills/refactor/SKILL.md |
Regenerated refactor skill artifact. |
.github/skills/rancher/SKILL.md |
Adds generated Rancher skill artifact. |
.github/skills/performance/SKILL.md |
Regenerated performance skill artifact. |
.github/skills/openapi/SKILL.md |
Regenerated openapi skill artifact. |
.github/skills/onboard/SKILL.md |
Regenerated onboard skill artifact. |
.github/skills/migrate/SKILL.md |
Regenerated migrate skill artifact. |
.github/skills/inspect/SKILL.md |
Regenerated inspect skill artifact. |
.github/skills/incident/SKILL.md |
Regenerated incident skill artifact. |
.github/skills/guardrails/SKILL.md |
Regenerated guardrails skill artifact. |
.github/skills/explore/SKILL.md |
Regenerated explore skill artifact. |
.github/skills/docs/SKILL.md |
Regenerated docs skill artifact. |
.github/skills/design/SKILL.md |
Regenerated design skill artifact. |
.github/skills/dependency/SKILL.md |
Regenerated dependency skill artifact. |
.github/skills/debug/SKILL.md |
Regenerated debug skill artifact. |
.github/skills/container/SKILL.md |
Regenerated container skill artifact. |
.github/skills/consult/SKILL.md |
Regenerated consult skill artifact. |
.github/skills/concise/SKILL.md |
Regenerated concise skill artifact. |
.github/skills/code-review/SKILL.md |
Regenerated code-review skill artifact. |
.github/skills/architecture/SKILL.md |
Regenerated architecture skill artifact. |
.github/skills/analyse/SKILL.md |
Regenerated analyse skill artifact. |
.github/skills/adr/SKILL.md |
Regenerated ADR skill artifact. |
.github/prompts/release-readiness.prompt.md |
Adds generated release-readiness prompt. |
.github/prompts/migration-safety.prompt.md |
Adds generated migration-safety prompt. |
.github/prompts/incident-timeline.prompt.md |
Adds generated incident-timeline prompt. |
.github/prompts/dependency-audit.prompt.md |
Adds generated dependency-audit prompt. |
.github/prompts/code-review.prompt.md |
Regenerates code-review prompt. |
.github/prompts/architecture-risk.prompt.md |
Adds generated architecture-risk prompt. |
.github/prompts/api-design-review.prompt.md |
Adds generated api-design-review prompt. |
.github/instructions/typescript.instructions.md |
Adds generated TypeScript instruction artifact. |
.github/instructions/testing.instructions.md |
Adds generated testing instruction artifact. |
.github/instructions/terragrunt.instructions.md |
Adds generated Terragrunt instruction artifact. |
.github/instructions/terraform.instructions.md |
Adds generated Terraform instruction artifact. |
.github/instructions/security.instructions.md |
Adds generated security instruction artifact. |
.github/instructions/rancher.instructions.md |
Adds generated Rancher instruction artifact. |
.github/instructions/python.instructions.md |
Regenerates Python instruction artifact. |
.github/instructions/markdown.instructions.md |
Adds generated Markdown instruction artifact. |
.github/instructions/k8s.instructions.md |
Adds generated Kubernetes instruction artifact. |
.github/instructions/java.instructions.md |
Adds generated Java instruction artifact. |
.github/instructions/helm.instructions.md |
Adds generated Helm instruction artifact. |
.github/instructions/git.instructions.md |
Regenerates Git instruction artifact. |
.github/agents/release.agent.md |
Regenerated release agent artifact. |
.github/agents/product.agent.md |
Regenerated product agent artifact. |
.github/agents/designer.agent.md |
Regenerated designer agent artifact. |
.github/agents/architect.agent.md |
Regenerated architect agent artifact. |
…tests commit types - Fix YAML alias token bug: FieldSpec applyTo now emits quoted values so globs starting with ** are valid YAML in consumer repos - Add test and tests to allow_commit_types in cchk.toml and changelog-sections in .release-please-config.json - Document test/tests in CONTRIBUTING.md allowed types and version bump rules - Sync README-pypi.md with building blocks table and prompt catalog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the vstack skill and instruction catalog from its baseline to 42 skills and 12
instructions, along with matching agent wiring, documentation, prompts, and tooling fixes.
Skills added (15 new):
conventional-commit— Conventional Commit message preparation and validationgh-release— GitHub Release creation and publication viaghCLIthreat-model— STRIDE/DREAD/PASTA threat modelinggh-issues— GitHub issue creation and management viaghCLIcodeql— CodeQL code scanning setup and configurationdependabot— Dependabot configuration and PR noise reductionsecret-scan— GitHub secret scanning and push protection configurationgdpr— GDPR-compliant engineering practicesterraform— Terraform infrastructure-as-code authoring and reviewterragrunt— Terragrunt DRY multi-environment infrastructurecloudformation— AWS CloudFormation template authoring and reviewaws-cli— AWS CLI command reference and workflow patternsk8s— Kubernetes manifest authoring, review, and troubleshootinghelm— Helm chart authoring, review, and release lifecyclerancher— Rancher/Fleet cluster governance and workload operationsInstructions added (5 new):
typescript— TypeScript/JavaScript coding conventionsjava— Java coding conventionsterraform— Terraform coding conventionsterragrunt— Terragrunt coding conventionsk8s/helm/rancher— Platform engineering coding conventionsOther changes:
applyToglob values in generated instruction frontmatter now always emitted with single quotes (fixes YAML alias token ambiguity for values starting with**)testandtestsadded as allowed commit types tocchk.toml,release-please-config.json, andCONTRIBUTING.mdengineer,tester) updated with new skill referencesapi-design-review,dependency-audit,architecture-risk,incident-timeline,migration-safety,release-readinessskills.md,instructions.md,agents.md) updated to reflect current catalogWhy
The baseline skill set covered general engineering procedures but lacked coverage for
infrastructure-as-code, security tooling, cloud operations, and platform engineering
workflows that are routine in backend and DevOps contexts. This brings the catalog to
a point where the most commonly needed skills are available without ad hoc prompting.
The
applyToquoting fix prevents YAML parse errors in consumer repos when VS Codeor other tools attempt to load instruction frontmatter.
The commit type policy fix (
test/tests) aligns the enforcement configuration withhow test-only commits are already used in practice.
Version impact