Skip to content

Fix/dependabot pytest pygments - #6

Merged
eschaar merged 9 commits into
mainfrom
fix/dependabot-pytest-pygments
Apr 19, 2026
Merged

Fix/dependabot pytest pygments#6
eschaar merged 9 commits into
mainfrom
fix/dependabot-pytest-pygments

Conversation

@eschaar

@eschaar eschaar commented Apr 19, 2026

Copy link
Copy Markdown
Owner

Summary

This PR finalizes the Dependabot security bump and bundles the full follow-up hardening work around newly added skills/templates.

What changed:

  • Added 6 new skills and wired them into install/generation flow:
    • migrate, openapi, refactor, onboard, dependency, incident
  • Fixed nested Markdown fence issues in onboarding/refactor templates so embedded code blocks render correctly.
  • Updated changelog entries for template-fence fixes.
  • Improved template quality across the new skills (consistency and stronger review guidance).
  • Hardened dependency skill shell snippets:
    • Removed precedence pitfalls (|| / &&) in manifest checks.
    • Reworked fallback behavior so install hints only appear when relevant tools/projects are present.
    • Avoided fragile ... | head ... || fallback behavior by using explicit tool checks and structured conditionals.
  • Included Dependabot-related pytest/pygments updates.

Why:

  • Prevent false positives/misleading fallback messages in scanner instructions.
  • Ensure generated skill docs render correctly and are copy/paste safe.
  • Keep vstack templates reliable for downstream repos.

Related Issues

  • Dependabot security update context for pytest/pygments (no direct issue link provided in this branch).

Validation

  • Tests pass locally
  • CI checks pass
  • Docs updated (if needed)

Local validation run:

  • pytest passed: 187 passed, 100% coverage

Release Impact

  • feat: (minor)
  • fix: (patch)
  • BREAKING CHANGE (major)
  • No release impact

eschaar added 3 commits April 19, 2026 13:38
Skills added: migrate, openapi, refactor, onboard, dependency, incident.

- src/vstack/_templates/skills/{migrate,openapi,refactor,onboard,dependency,incident}/
- .github/skills/{migrate,openapi,refactor,onboard,dependency,incident}/SKILL.md
- agent templates updated: engineer, designer, tester, product
- .github/agents/{engineer,designer,tester,product}.agent.md regenerated
- .github/vstack.json updated (26 skills)
- docs/design/skills.md updated with full skill table
- README.md updated: structure diagram, roles table
- .github/copilot-instructions.md updated: structure + install table
- CHANGELOG.md: added 1.0.2, 1.0.3, and [Unreleased] 1.0.4 entries
- tests/conftest.py + src/vstack/cli/constants.py: EXPECTED_CANONICAL_NAMES updated to 26 skills
Copilot AI review requested due to automatic review settings April 19, 2026 19:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependency tooling to address security advisories and expands vstack’s skill/agent template set by adding six new skills (with regenerated .github/ artifacts) and aligning docs and constants to the expanded skill catalog.

Changes:

  • Bumped dev dependencies (notably pytest and pygments) and refreshed the Poetry lockfile and pre-commit hook revisions.
  • Added new skill templates/configs for migrate, openapi, refactor, onboard, dependency, and incident, plus generated .github/skills/* outputs and updated agent templates to reference the new skills.
  • Updated skill canonical-name lists, docs index tables, README structure/role tables, Copilot instructions, and CHANGELOG entries to reflect the expanded skill set.

Reviewed changes

Copilot reviewed 34 out of 35 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/conftest.py Extends the test canonical skill-name list to include the 6 new skills.
src/vstack/cli/constants.py Extends CLI canonical skill-name list used for validation/verify flows.
src/vstack/_templates/skills/refactor/template.md Adds new refactor skill template (source of truth).
src/vstack/_templates/skills/refactor/config.yaml Adds refactor skill metadata/config.
src/vstack/_templates/skills/openapi/template.md Adds new openapi skill template (source of truth).
src/vstack/_templates/skills/openapi/config.yaml Adds openapi skill metadata/config.
src/vstack/_templates/skills/onboard/template.md Adds new onboard skill template (source of truth).
src/vstack/_templates/skills/onboard/config.yaml Adds onboard skill metadata/config.
src/vstack/_templates/skills/migrate/template.md Adds new migrate skill template (source of truth).
src/vstack/_templates/skills/migrate/config.yaml Adds migrate skill metadata/config.
src/vstack/_templates/skills/incident/template.md Adds new incident skill template (source of truth).
src/vstack/_templates/skills/incident/config.yaml Adds incident skill metadata/config.
src/vstack/_templates/skills/dependency/template.md Adds new dependency skill template (source of truth).
src/vstack/_templates/skills/dependency/config.yaml Adds dependency skill metadata/config.
src/vstack/_templates/agents/tester/template.md Updates tester agent template to reference new skills.
src/vstack/_templates/agents/product/template.md Updates product agent template to reference onboard.
src/vstack/_templates/agents/engineer/template.md Updates engineer agent template to reference new skills.
src/vstack/_templates/agents/designer/template.md Updates designer agent template to reference openapi.
poetry.lock Updates locked dependency graph consistent with the dependency bumps.
docs/design/skills.md Extends skills index table to include the 6 new skills.
README.md Updates role→primary skills table and template-source-of-truth documentation/structure diagram.
CHANGELOG.md Records the new skills and related documentation/template changes under Unreleased.
.pre-commit-config.yaml Updates pre-commit hook revisions (ruff, mdformat, markdownlint, etc.).
.github/vstack.json Updates install manifest with new artifacts and install timestamp/version.
.github/skills/refactor/SKILL.md Adds generated refactor skill output.
.github/skills/openapi/SKILL.md Adds generated openapi skill output.
.github/skills/onboard/SKILL.md Adds generated onboard skill output.
.github/skills/migrate/SKILL.md Adds generated migrate skill output.
.github/skills/incident/SKILL.md Adds generated incident skill output.
.github/skills/dependency/SKILL.md Adds generated dependency skill output.
.github/copilot-instructions.md Updates Copilot instructions to reflect additional artifact types and install rules.
.github/agents/tester.agent.md Regenerated tester agent with new skill references.
.github/agents/product.agent.md Regenerated product agent with new skill references.
.github/agents/engineer.agent.md Regenerated engineer agent with new skill references.
.github/agents/designer.agent.md Regenerated designer agent with new skill references.

Comment thread src/vstack/_templates/skills/refactor/template.md Outdated
Comment thread src/vstack/_templates/skills/refactor/template.md Outdated
Comment thread .github/skills/refactor/SKILL.md Outdated
Comment thread src/vstack/_templates/skills/onboard/template.md
Comment thread src/vstack/_templates/skills/onboard/template.md Outdated
Comment thread src/vstack/_templates/skills/refactor/template.md Outdated
eschaar added 5 commits April 19, 2026 21:13
- refactor: use <base> instead of hardcoded origin/main in git diff
- dependency: remove unused {{BASE_BRANCH}} partial
- migrate: add git diff <base> to show changed migration files in branch
- openapi: add operationId and summary checks to Part 2
- incident: add runbook action item to Step 5 response category

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 34 out of 35 changed files in this pull request and generated 4 comments.

Comment thread src/vstack/_templates/skills/dependency/template.md Outdated
Comment thread src/vstack/_templates/skills/dependency/template.md Outdated
Comment thread src/vstack/_templates/skills/dependency/template.md Outdated
Comment thread src/vstack/_templates/skills/dependency/template.md Outdated
@eschaar
eschaar merged commit d4fbfcc into main Apr 19, 2026
11 checks passed
@eschaar
eschaar deleted the fix/dependabot-pytest-pygments branch April 19, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants