Skip to content

Fix/workflow permissions - #7

Merged
eschaar merged 3 commits into
mainfrom
fix/workflow-permissions
Apr 19, 2026
Merged

Fix/workflow permissions#7
eschaar merged 3 commits into
mainfrom
fix/workflow-permissions

Conversation

@eschaar

@eschaar eschaar commented Apr 19, 2026

Copy link
Copy Markdown
Owner

Summary

This PR prepares the 1.0.5 release line with workflow hardening and manifest refresh.

What changed:

  • Added explicit GitHub Actions permissions across workflows to satisfy policy checks and enforce least privilege.
  • Updated release workflow permissions to default read-only, with write access scoped only to the version-and-release job.
  • Normalized verify workflow syntax to use on: style consistent with the other workflows.
  • Refreshed the generated vstack install manifest metadata.
  • Updated changelog entries so 1.0.4 remains the released set and the latest branch changes are tracked as 1.0.5.

Why:

  • Ensure workflow security policy compliance.
  • Reduce token permission scope in CI/CD.
  • Keep generated metadata and release documentation aligned.

Related Issues

  • No linked issue.
  • Follow-up from workflow policy warning: Workflow does not contain permissions.

Validation

  • Tests pass locally
  • CI checks pass
  • Docs updated (if needed)

Release Impact

  • feat: (minor)
  • fix: (patch)
  • BREAKING CHANGE (major)
  • No release impact

Copilot AI review requested due to automatic review settings April 19, 2026 20:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens GitHub Actions workflows for the 1.0.5 release line by explicitly declaring least-privilege permissions, updating the release workflow to minimize write scope, and refreshing the generated vstack install manifest metadata. It also updates the changelog to track the latest branch work under 1.0.5 while keeping 1.0.4 as the released set.

Changes:

  • Added explicit workflow-level permissions to QA, Verify, and Security workflows.
  • Updated Release workflow to default to contents: read and grant contents: write only to the tagging/release job.
  • Refreshed .github/vstack.json metadata and updated CHANGELOG.md for 1.0.5.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
CHANGELOG.md Adds 1.0.5 entry describing workflow permission hardening and manifest refresh.
.github/workflows/verify.yml Normalizes on: syntax and declares read-only workflow permissions.
.github/workflows/security.yml Declares explicit read permissions needed for PR-context scanning steps.
.github/workflows/release.yml Makes workflow token read-only by default; scopes write to the release job.
.github/workflows/qa.yml Declares explicit read-only workflow permissions for CI checks.
.github/vstack.json Updates generated install manifest timestamp metadata.

@eschaar
eschaar merged commit 4d7b770 into main Apr 19, 2026
15 checks passed
@eschaar
eschaar deleted the fix/workflow-permissions branch April 19, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants