Feat/planner ask explore quick review - #75
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends vstack’s repository/Q&A capabilities by adding a new read-only ask skill, tightening “explore” into a faster reuse-focused discovery flow, and renaming the code-review prompt artifact to quick-review while making prompts/agents more model-agnostic.
Changes:
- Add
askskill (templates + generated skill) and wire it into canonical name lists and user docs. - Revise
exploreskill to support depth modes and reuse-first evidence gathering. - Rename the prompt artifact from
code-review→quick-review, remove prompt model pinning across templates, and regenerate docs/fixtures/artifacts accordingly.
Reviewed changes
Copilot reviewed 148 out of 151 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/vstack/cli/test_constants.py | Add ask to canonical CLI name expectations. |
| tests/vstack/artifacts/test_generator.py | Update golden fixture test to quick-review. |
| tests/vstack/agents/test_generation.py | Assert agent frontmatter omits model. |
| tests/_fixtures/golden/prompts/quick-review.prompt.md | Update prompt golden fixture for quick-review. |
| tests/_fixtures/golden/prompts/api-design-review.prompt.md | Update API-design prompt golden fixture wording/footer. |
| tests/_fixtures/golden/instructions/testing.instructions.md | Update testing instruction golden fixture wording/footer. |
| tests/_fixtures/golden/instructions/security.instructions.md | Update security instruction golden fixture wording/footer. |
| tests/_fixtures/golden/agents/product.agent.md | Update product agent golden fixture (stage report schema changes). |
| tests/_fixtures/golden/agents/planner.agent.md | Update planner agent golden fixture (planning + stage report changes). |
| src/vstack/cli/constants.py | Add ask; switch artifact state from code-review to quick-review. |
| src/vstack/_templates/skills/space-setup/template.md | Adjust guidance trigger wording. |
| src/vstack/_templates/skills/explore/template.md | Overhaul explore workflow into fast Q&A + reuse discovery. |
| src/vstack/_templates/skills/explore/config.yaml | Update explore version/description for new behavior. |
| src/vstack/_templates/skills/ask/template.md | Add new read-only technical Q&A skill template. |
| src/vstack/_templates/skills/ask/config.yaml | Add new ask skill config. |
| src/vstack/_templates/prompts/workflow-check/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/upgrade-plan/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/test-gaps/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/template-impact/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/repo-assessment/template.md | Tighten wording; keep output contract intact. |
| src/vstack/_templates/prompts/repo-assessment/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/release-check/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/quick-review/template.md | Introduce new quick-review prompt template body. |
| src/vstack/_templates/prompts/quick-review/config.yaml | Rename prompt artifact code-review → quick-review. |
| src/vstack/_templates/prompts/ops-readiness/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/migration-safety/template.md | Minor wording tweak (“reads and writes”). |
| src/vstack/_templates/prompts/migration-safety/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/migration-plan/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/incident-timeline/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/dependency-audit/template.md | Tighten wording; keep output contract intact. |
| src/vstack/_templates/prompts/dependency-audit/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/ci-triage/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/artifact-integrity/template.md | Tighten wording; keep output contract intact. |
| src/vstack/_templates/prompts/artifact-integrity/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/architecture-risk/template.md | Minor wording tweak (“Ignore stylistic preferences”). |
| src/vstack/_templates/prompts/architecture-risk/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/prompts/api-design-review/template.md | Tighten wording; keep output contract intact. |
| src/vstack/_templates/prompts/api-design-review/config.yaml | Remove pinned model for model-agnostic prompt. |
| src/vstack/_templates/instructions/typescript/template.md | Tighten wording across TS conventions. |
| src/vstack/_templates/instructions/testing/template.md | Tighten wording across testing conventions. |
| src/vstack/_templates/instructions/terragrunt/template.md | Tighten wording across Terragrunt conventions. |
| src/vstack/_templates/instructions/terraform/template.md | Tighten wording across Terraform conventions. |
| src/vstack/_templates/instructions/security/template.md | Tighten wording across security conventions. |
| src/vstack/_templates/instructions/rancher/template.md | Tighten wording across Rancher conventions. |
| src/vstack/_templates/instructions/python/template.md | Tighten wording across Python conventions. |
| src/vstack/_templates/instructions/markdown/template.md | Tighten wording across Markdown conventions. |
| src/vstack/_templates/instructions/k8s/template.md | Tighten wording across Kubernetes conventions. |
| src/vstack/_templates/instructions/java/template.md | Tighten wording across Java conventions. |
| src/vstack/_templates/instructions/helm/template.md | Tighten wording across Helm conventions. |
| src/vstack/_templates/instructions/git/template.md | Tighten wording across Git conventions. |
| src/vstack/_templates/agents/tester/config.yaml | Remove agent model override to stay model-agnostic. |
| src/vstack/_templates/agents/release/config.yaml | Remove agent model override to stay model-agnostic. |
| src/vstack/_templates/agents/product/config.yaml | Remove agent model override to stay model-agnostic. |
| src/vstack/_templates/agents/planner/template.md | Add collaborative planning + budget/state guidance. |
| src/vstack/_templates/agents/planner/config.yaml | Remove agent model override to stay model-agnostic. |
| src/vstack/_templates/agents/engineer/config.yaml | Remove agent model override to stay model-agnostic. |
| src/vstack/_templates/agents/designer/config.yaml | Remove agent model override to stay model-agnostic. |
| src/vstack/_templates/agents/architect/config.yaml | Remove agent model override to stay model-agnostic. |
| src/vstack/_templates/agents/_partials/stage-report-contract.md | Expand stage report schema (plan delta + token budget). |
| pyproject.toml | Bump PyYAML minimum version. |
| poetry.lock | Regenerate lockfile with updated dependency set. |
| docs/user/reference/skills-overview.md | Document new ask skill; refresh explore description. |
| docs/user/reference/prompts-overview.md | Add prompt scope column; rename to quick-review; model-agnostic note. |
| docs/product/roadmap.md | Refresh roadmap status and shipped items; update prompt reference. |
| docs/design/skills.md | Add ask to the design-level skills table. |
| docs/design/agents.md | Update guidance: model is optional/omit by default. |
| .pre-commit-config.yaml | Update ruff-pre-commit rev. |
| .gitignore | Ignore .pytest-tmp/. |
| .github/skills/vision/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/verify/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/threat-model/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/terragrunt/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/terraform/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/space-setup/SKILL.md | Regenerate skill content/footer (space-setup wording). |
| .github/skills/security/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/secret-scan/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/requirements/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/release-notes/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/refactor/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/rca/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/rancher/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/pr/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/postmortem/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/performance/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/openapi/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/onboard/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/migrate/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/k8s/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/inspect/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/incident/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/helm/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/guardrails/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/gh-release/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/gh-issues/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/gdpr/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/explore/SKILL.md | Regenerate explore skill with new fast exploration content. |
| .github/skills/docs/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/design/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/dependency/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/dependabot/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/debug/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/copilot-ops/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/conventional-commit/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/container/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/consult/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/concise/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/codeql/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/code-review/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/cloudformation/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/cicd/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/aws-cli/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/ask/SKILL.md | Add generated ask skill artifact. |
| .github/skills/architecture/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/analyse/SKILL.md | Regenerate skill footer metadata. |
| .github/skills/adr/SKILL.md | Regenerate skill footer metadata. |
| .github/prompts/workflow-check.prompt.md | Regenerate prompt without model pin. |
| .github/prompts/upgrade-plan.prompt.md | Regenerate prompt without model pin. |
| .github/prompts/test-gaps.prompt.md | Regenerate prompt without model pin. |
| .github/prompts/template-impact.prompt.md | Regenerate prompt without model pin. |
| .github/prompts/repo-assessment.prompt.md | Regenerate prompt (wording tightened; no model pin). |
| .github/prompts/release-check.prompt.md | Regenerate prompt without model pin. |
| .github/prompts/quick-review.prompt.md | Rename/regenerate prompt to quick-review. |
| .github/prompts/ops-readiness.prompt.md | Regenerate prompt without model pin. |
| .github/prompts/migration-safety.prompt.md | Regenerate prompt (minor wording; no model pin). |
| .github/prompts/migration-plan.prompt.md | Regenerate prompt without model pin. |
| .github/prompts/incident-timeline.prompt.md | Regenerate prompt without model pin. |
| .github/prompts/dependency-audit.prompt.md | Regenerate prompt (wording tightened; no model pin). |
| .github/prompts/ci-triage.prompt.md | Regenerate prompt without model pin. |
| .github/prompts/artifact-integrity.prompt.md | Regenerate prompt (wording tightened; no model pin). |
| .github/prompts/architecture-risk.prompt.md | Regenerate prompt (minor wording; no model pin). |
| .github/prompts/api-design-review.prompt.md | Regenerate prompt (wording tightened; no model pin). |
| .github/instructions/typescript.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/testing.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/terragrunt.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/terraform.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/security.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/rancher.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/python.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/markdown.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/k8s.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/java.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/helm.instructions.md | Regenerate instruction output from updated template. |
| .github/instructions/git.instructions.md | Regenerate instruction output from updated template. |
| .github/agents/tester.agent.md | Regenerate agent output (stage report schema additions). |
| .github/agents/release.agent.md | Regenerate agent output (stage report schema additions). |
| .github/agents/product.agent.md | Regenerate agent output (stage report schema additions). |
| .github/agents/planner.agent.md | Regenerate planner output (planning + stage report schema additions). |
| .github/agents/engineer.agent.md | Regenerate agent output (stage report schema additions). |
| .github/agents/designer.agent.md | Regenerate agent output (stage report schema additions). |
| .github/agents/architect.agent.md | Regenerate agent output (stage report schema additions). |
Comments suppressed due to low confidence (1)
tests/_fixtures/golden/prompts/quick-review.prompt.md:53
- Golden fixture metadata uses
vstack_version3.5.2, but the repo’s generated prompt (.github/prompts/quick-review.prompt.md) and install manifest (.vstack/vstack.json) are on 3.5.1. This inconsistency makes fixture drift hard to reason about; fixtures should match the actual generator output/version used in this repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.