Skip to content

Feature/concise mode - #8

Merged
eschaar merged 2 commits into
mainfrom
feature/concise-mode
Apr 19, 2026
Merged

Feature/concise mode#8
eschaar merged 2 commits into
mainfrom
feature/concise-mode

Conversation

@eschaar

@eschaar eschaar commented Apr 19, 2026

Copy link
Copy Markdown
Owner

Summary

Implemented a comprehensive prompt-architecture cleanup and consistency pass across roles and skills.

This PR combines the concise-mode feature work with a full agent/skill boundary refactor to reduce template size, remove duplicated procedural guidance, and make role handoffs/gates explicit and consistent.

Key outcomes:

  • Added and wired the concise skill across all roles with per-role defaults.
  • Standardized all six agent templates to a shared structure (responsibilities/scope, principles, communication style, gate moments and handoffs, how-you-work, deliverables/success, escalation, skills).
  • Moved procedural detail from agents into skills (agents now focus on ownership, decisions, and gates).
  • Added/normalized Deliverable and artifact policy sections across relevant skills.
  • Clarified release ownership: release-notes owns both docs/releases/{date}.md and CHANGELOG.md; pr owns push/PR creation.
  • Made performance baseline and observability evidence scope-conditional instead of always mandatory.
  • Regenerated .github artifacts from template source of truth.

Net effect: clearer role boundaries, stronger agent↔skill contracts, lower prompt footprint, and a single coherent 1.1.0 release scope.

Related Issues

  • N/A (template and workflow consistency refactor)
  • ADR references: existing docs/architecture/adr/* remain applicable; no new ADR required for this templating-only restructuring.

Validation

  • Tests pass locally
  • CI checks pass
  • Docs updated (if needed)

Validation notes:

  • Local suite: 188 passed
  • Coverage gate: 100%

Release Impact

  • feat: (minor)
  • fix: (patch)
  • BREAKING CHANGE (major)
  • No release impact

Copilot AI review requested due to automatic review settings April 19, 2026 22:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces the new concise runtime response-style skill and performs a broad template refactor to standardize agent structure, reduce duplicated procedural guidance, and clarify artifact ownership/handoffs across the vstack role/skill system.

Changes:

  • Added the concise skill (templates, config, CLI canonical name wiring) and referenced it from all six role agents with per-role defaults.
  • Standardized agent templates around a shared structure and moved procedural detail into skills, including explicit gate moments/handoffs.
  • Added/normalized “Deliverable and artifact policy” sections and expanded verification observability checks; regenerated .github/ artifacts and updated docs/README/CHANGELOG.

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/vstack/agents/test_role_wiring.py Adds regression coverage ensuring all role templates reference @#concise.
tests/conftest.py Removes duplicated canonical skill list (but currently breaks downstream imports/tests).
src/vstack/cli/constants.py Adds concise to the canonical skill name list.
src/vstack/_templates/skills/vision/template.md Adds deliverable/artifact policy section.
src/vstack/_templates/skills/verify/template.md Adds deliverable/artifact policy and observability evidence requirements (scope-dependent).
src/vstack/_templates/skills/security/template.md Adds deliverable/artifact policy section.
src/vstack/_templates/skills/requirements/template.md Adds deliverable/artifact policy section.
src/vstack/_templates/skills/release-notes/template.md Clarifies ownership of release artifacts and adds deliverable/artifact policy + scope-conditional checks.
src/vstack/_templates/skills/pr/template.md Adds deliverable/artifact policy and PR body sourcing guidance.
src/vstack/_templates/skills/performance/template.md Adds deliverable/artifact policy section.
src/vstack/_templates/skills/inspect/template.md Adds deliverable/artifact policy and observability/reliability checks section.
src/vstack/_templates/skills/docs/template.md Adds deliverable/artifact policy section.
src/vstack/_templates/skills/design/template.md Adds deliverable/artifact policy and minor formatting cleanup.
src/vstack/_templates/skills/concise/template.md Introduces the concise skill body defining modes, precedence, and expected responses.
src/vstack/_templates/skills/concise/config.yaml Adds concise skill metadata/config for generation and slash-command UX.
src/vstack/_templates/skills/architecture/template.md Adds deliverable/artifact policy and ADR recording guidance.
src/vstack/_templates/agents/tester/template.md Refactors tester agent to standardized structure; adds @#concise and scope-conditional perf baseline language.
src/vstack/_templates/agents/release/template.md Refactors release agent to standardized structure; clarifies gates/handoffs and artifact checks.
src/vstack/_templates/agents/product/template.md Refactors product agent to standardized structure; adds @#concise and explicit gate moments.
src/vstack/_templates/agents/engineer/template.md Refactors engineer agent to standardized structure; adds @#concise and streamlined “how you work”.
src/vstack/_templates/agents/designer/template.md Refactors designer agent to standardized structure; adds @#concise and explicit gate moments/handoffs.
src/vstack/_templates/agents/architect/template.md Refactors architect agent to standardized structure; adds @#concise and explicit gates/handoffs.
src/vstack/_templates/agents/_partials/agent-skill-boundary.md Adds shared agent-skill boundary partial for reuse across role templates.
docs/design/skills.md Adds concise to the skill index table and keeps skill invocation contract documented.
README.md Updates role table with default concise modes and documents concise usage.
CHANGELOG.md Adds 1.1.0 release notes describing concise + refactor.
.github/vstack.json Updates generated install manifest metadata and adds concise artifact entry.
.github/skills/vision/SKILL.md Regenerated skill output reflecting template updates.
.github/skills/verify/SKILL.md Regenerated skill output reflecting template updates.
.github/skills/security/SKILL.md Regenerated skill output reflecting template updates.
.github/skills/requirements/SKILL.md Regenerated skill output reflecting template updates.
.github/skills/release-notes/SKILL.md Regenerated skill output reflecting template updates.
.github/skills/pr/SKILL.md Regenerated skill output reflecting template updates.
.github/skills/performance/SKILL.md Regenerated skill output reflecting template updates.
.github/skills/inspect/SKILL.md Regenerated skill output reflecting template updates.
.github/skills/docs/SKILL.md Regenerated skill output reflecting template updates.
.github/skills/design/SKILL.md Regenerated skill output reflecting template updates.
.github/skills/concise/SKILL.md New generated skill output for concise.
.github/skills/architecture/SKILL.md Regenerated skill output reflecting template updates.
.github/agents/tester.agent.md Regenerated agent output reflecting template refactor + concise.
.github/agents/release.agent.md Regenerated agent output reflecting template refactor + concise.
.github/agents/product.agent.md Regenerated agent output reflecting template refactor + concise.
.github/agents/engineer.agent.md Regenerated agent output reflecting template refactor + concise.
.github/agents/designer.agent.md Regenerated agent output reflecting template refactor + concise.
.github/agents/architect.agent.md Regenerated agent output reflecting template refactor + concise.

Comment thread tests/conftest.py
Comment thread src/vstack/_templates/agents/release/template.md Outdated
Comment thread README.md Outdated
@eschaar
eschaar force-pushed the feature/concise-mode branch from 6fb487a to d44d191 Compare April 19, 2026 22:32
@eschaar
eschaar force-pushed the feature/concise-mode branch from d44d191 to e5fb821 Compare April 19, 2026 22:43
@eschaar
eschaar merged commit e6bef21 into main Apr 19, 2026
11 checks passed
@eschaar
eschaar deleted the feature/concise-mode branch April 19, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants