Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/skills/refactor/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -236,13 +236,15 @@ def process_order(order):
# process
...


# After
def _validate_order(order: dict) -> None:
if not order.get("id"):
raise ValueError("missing id")
if order.get("amount", 0) <= 0:
raise ValueError("amount must be positive")


def process_order(order: dict) -> None:
_validate_order(order)
...
Expand All @@ -259,6 +261,7 @@ def process(item):
return item.value * 2
return None


# After
def process(item):
if item is None:
Expand Down Expand Up @@ -289,8 +292,8 @@ if status_code == HTTP_TOO_MANY_REQUESTS:

```python
# Before
def create_user(name, email, role, department, manager_id, start_date):
...
def create_user(name, email, role, department, manager_id, start_date): ...


# After
@dataclass
Expand All @@ -302,8 +305,8 @@ class CreateUserRequest:
manager_id: str
start_date: date

def create_user(request: CreateUserRequest) -> User:
...

def create_user(request: CreateUserRequest) -> User: ...
```

## Step 5: Verify
Expand Down
52 changes: 26 additions & 26 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,10 @@ poetry-dynamic-versioning = { version = ">=1.10.0,<2.0.0", extras = ["plugin"] }
[tool.poetry.group.dev.dependencies]
pytest = ">=9.1.1"
pytest-cov = ">=7.1.0"
ruff = ">=0.15.22"
ruff = ">=0.16.0"
mypy = ">=2.3.0"
pre-commit = ">=4.6.0"
tox = ">=4.57.0"
pre-commit = ">=4.6.1"
tox = ">=4.58.0"
types-PyYAML = ">=6.0.12.20260724"


Expand Down
11 changes: 7 additions & 4 deletions src/vstack/_templates/skills/refactor/template.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,15 @@ def process_order(order):
# process
...


# After
def _validate_order(order: dict) -> None:
if not order.get("id"):
raise ValueError("missing id")
if order.get("amount", 0) <= 0:
raise ValueError("amount must be positive")


def process_order(order: dict) -> None:
_validate_order(order)
...
Expand All @@ -177,6 +179,7 @@ def process(item):
return item.value * 2
return None


# After
def process(item):
if item is None:
Expand Down Expand Up @@ -207,8 +210,8 @@ if status_code == HTTP_TOO_MANY_REQUESTS:

```python
# Before
def create_user(name, email, role, department, manager_id, start_date):
...
def create_user(name, email, role, department, manager_id, start_date): ...


# After
@dataclass
Expand All @@ -220,8 +223,8 @@ class CreateUserRequest:
manager_id: str
start_date: date

def create_user(request: CreateUserRequest) -> User:
...

def create_user(request: CreateUserRequest) -> User: ...
```

## Step 5: Verify
Expand Down