feat: reveal workspace paths in the system file manager#3070
Closed
YoungDan-hero wants to merge 1 commit into
Closed
feat: reveal workspace paths in the system file manager#3070YoungDan-hero wants to merge 1 commit into
YoungDan-hero wants to merge 1 commit into
Conversation
This PR addresses a desktop workflow gap where the file tree context menu could only add file or folder references to chat. During development, users also need to locate the selected item in the native file manager, such as Finder on macOS, File Explorer on Windows, or the default file manager on Linux. The change adds a file tree context menu action for both files and folders. The frontend displays platform-aware localized labels, calls the existing RevealWorkspacePath bridge, reports failures through the existing notice flow, and clears stale browser text selection when opening the context menu. The backend now keeps App.RevealWorkspacePath focused on workspace path validation and delegates platform command construction to a dedicated helper. macOS uses open -R, Windows uses explorer /select,, and Linux opens the parent folder for files or the folder itself for directories. Cross-platform command tests were added to reduce regression risk.
github-actions
Bot
added
the
v2
Owner
|
Thanks! This already landed on main-v2 along the way — there's now a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a desktop workflow gap where the file tree context menu could only add file or folder references to chat. During development, users also need to locate the selected item in the native file manager, such as Finder on macOS, File Explorer on Windows, or the default file manager on Linux.
The change adds a file tree context menu action for both files and folders. The frontend displays platform-aware localized labels, calls the existing RevealWorkspacePath bridge, reports failures through the existing notice flow, and clears stale browser text selection when opening the context menu.
The backend now keeps App.RevealWorkspacePath focused on workspace path validation and delegates platform command construction to a dedicated helper. macOS uses open -R, Windows uses explorer /select,, and Linux opens the parent folder for files or the folder itself for directories. Cross-platform command tests were added to reduce regression risk.
Closes #3035