fix(desktop): guard null levels and text/reasoning/args in .length calls#3105
Open
jiaxindeyang-a11y wants to merge 1 commit into
Open
fix(desktop): guard null levels and text/reasoning/args in .length calls#3105jiaxindeyang-a11y wants to merge 1 commit into
jiaxindeyang-a11y wants to merge 1 commit into
Conversation
EffortSwitcher checked effort?.supported but then accessed effort.levels.length without a null guard — a nil []string from Go JSON serialization arrives as null and throws "Cannot read properties of null (reading 'length')". The same class of bug existed in Transcript's scrollVersion (items may carry null text/reasoning/args from wire events) and in the useEffect dependency array where live?.text.length used single-level optional chaining.
github-actions
Bot
added
the
v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EffortSwitcher checked effort?.supported but then accessed effort.levels.length without a null guard — a nil []string from Go JSON serialization arrives as null and throws "Cannot read properties of null (reading 'length')".
The same class of bug existed in Transcript's scrollVersion (items may carry null text/reasoning/args from wire events) and in the useEffect dependency array where live?.text.length used single-level optional chaining.