Skip to content

Allow null in setLocale to reset to app locale #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordyvanderhaegen merged 1 commit into from
Apr 26, 2026
Merged

Allow null in setLocale to reset to app locale #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/UnderscoreTranslatable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trait UnderscoreTranslatable
{
protected ?string $translationLocale = null;

public function setLocale(string $locale): self
public function setLocale(?string $locale): self
{
$this->translationLocale = $locale;

Expand Down
13 changes: 13 additions & 0 deletions tests/UnderscoreTranslatableTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,19 @@ public function it_can_set_and_get_the_translation_locale(): void
$this->assertEquals('nl', $post->getLocale());
}

#[Test]
public function it_can_reset_the_translation_locale_by_passing_null(): void
{
config(['app.locale' => 'en']);

$post = new Post();
$post->setLocale('nl');
$this->assertEquals('nl', $post->getLocale());

$post->setLocale(null);
$this->assertEquals('en', $post->getLocale());
}

#[Test]
public function it_can_check_if_an_attribute_is_translatable(): void
{
Expand Down
Loading