Conversation
Facilitate: - construction of 'c' elements with capabilities - generating the 'node' for disco#info queries from the 'c' elements
This way, the client can process both the caps from XEP-0115 and XEP-0390 as well as handle special cases.
There was a problem hiding this comment.
Pull request overview
Adds stanza-building and parsing utilities to support XEP-0115 (Entity Capabilities v1) and XEP-0390 (Entity Capabilities 2.0), plus small Service Discovery helpers, while updating CI to stop testing on OTP 26.
Changes:
- Add
feature/1,identity/3,4helpers for XEP-0030 disco payload construction. - Add
caps/3,caps_to_node/1,ns_caps/1utilities for XEP-0115/XEP-0390 and update namespace macros accordingly. - Adjust stream feature parsing for server capabilities and drop OTP 26 from CI matrix.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/escalus_stanza.erl |
Adds new stanza constructors for disco features/identities and entity capabilities (v1/v2) plus helpers to derive a caps “node”. |
src/escalus_session.erl |
Changes how server caps are extracted from stream features (now returns <c/> elements list). |
include/escalus_xmlns.hrl |
Introduces namespaces for XEP-0300 hashes and XEP-0390 caps. |
.github/workflows/ci.yml |
Removes OTP 26 from the CI test matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is used in esl/MongooseIM#4666.
Details in commit messages.
Dropping Erlang/OTP 26 as we support 2 most recent versions in MongooseIM - so we can do it here as well to use the latest Erlang syntax additions.