Skip to content

Fix dialyzer errors #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timothyvanderaerden wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix dialyzer errors #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9bcbb
Fix `delivery_tag` type for `ack/3` and `reject/3`
timothyvanderaerden Oct 9, 2024
4ee92c8
Follow `basic_consume_ok/2` and `basic_deliver/3` contract
timothyvanderaerden Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/clients/adapter.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,15 @@ defmodule ExRabbitPool.Clients.Adapter do
{:ok, String.t()} | AMQP.Basic.error()
@callback cancel_consume(AMQP.Channel.t(), String.t(), keyword) ::
{:ok, String.t()} | {:error, AMQP.Basic.error()}
@callback ack(AMQP.Channel.t(), String.t(), keyword()) :: :ok | AMQP.Basic.error()
@callback reject(AMQP.Channel.t(), String.t(), keyword()) :: :ok | AMQP.Basic.error()
@callback ack(AMQP.Channel.t(), AMQP.Basic.delivery_tag(), keyword()) ::
:ok | AMQP.Basic.error()
@callback reject(AMQP.Channel.t(), AMQP.Basic.delivery_tag(), keyword()) ::
:ok | AMQP.Basic.error()
@callback declare_queue(AMQP.Channel.t(), AMQP.Basic.queue(), keyword()) ::
{:ok, map()} | AMQP.Basic.error()
@callback queue_bind(AMQP.Channel.t(), AMQP.Basic.queue(), AMQP.Basic.exchange(), keyword()) ::
:ok | AMQP.Basic.error()
@callback declare_exchange(AMQP.Channel.t(), AMQP.Basic.exchange(), keyword()) ::
:ok | AMQP.Basic.error()
@callback qos(AMQP.Channel.t(), keyword()) ::
:ok | AMQP.Basic.error()
@callback qos(AMQP.Channel.t(), keyword()) :: :ok | AMQP.Basic.error()
end
4 changes: 2 additions & 2 deletions lib/clients/fake_rabbitmq.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ defmodule ExRabbitPool.FakeRabbitMQ do
end

@impl true
def ack(_channel, _tag, _options \\ []) do
def ack(_channel, _delivery_tag, _options \\ []) do
:ok
end

@impl true
def reject(_channel, _tag, _options \\ []) do
def reject(_channel, _delivery_tag, _options \\ []) do
:ok
end

Expand Down
8 changes: 4 additions & 4 deletions lib/clients/rabbitmq.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ defmodule ExRabbitPool.RabbitMQ do
end

@impl true
def ack(%Channel{} = channel, tag, options \\ []) do
Basic.ack(channel, tag, options)
def ack(%Channel{} = channel, delivery_tag, options \\ []) do
Basic.ack(channel, delivery_tag, options)
end

@impl true
def reject(%Channel{} = channel, tag, options \\ []) do
Basic.reject(channel, tag, options)
def reject(%Channel{} = channel, delivery_tag, options \\ []) do
Basic.reject(channel, delivery_tag, options)
end

@impl true
Expand Down
6 changes: 0 additions & 6 deletions lib/consumer.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@ defmodule ExRabbitPool.Consumer do

{:stop, reason} ->
{:stop, reason, state}

_ ->
{:noreply, state}
end
end

Expand All @@ -133,9 +130,6 @@ defmodule ExRabbitPool.Consumer do

{:stop, reason} ->
{:stop, reason, state}

_ ->
{:noreply, state}
end
end

Expand Down