Skip to content

fix: make yank-to-system-clipboard work when the document isn't focused #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beenerdy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: make yank-to-system-clipboard work when the document isn't focused #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,9 +595,23 @@ export default class VimrcPlugin extends Plugin {
// yank -> clipboard
const buf = currentYankBuffer[0]
if (buf !== this.lastYankBuffer[0]) {
await win.navigator.clipboard.writeText(buf);
this.lastYankBuffer = currentYankBuffer;
this.lastSystemClipboard = await win.navigator.clipboard.readText();
try {
// `navigator.clipboard.writeText` rejects with "Document is not focused"
// during focus changes (the same failure the read path below guards
// against), silently dropping the yank. On the desktop app, Electron's
// clipboard is synchronous and focus-independent, so prefer it and fall
// back to the async API where `require` is unavailable (e.g. mobile).
const electronClipboard = (win as any).require?.('electron')?.clipboard;
if (electronClipboard) {
electronClipboard.writeText(buf);
} else {
await win.navigator.clipboard.writeText(buf);
}
this.lastYankBuffer = currentYankBuffer;
this.lastSystemClipboard = buf;
} catch (e) {
// Leave lastYankBuffer unchanged so a later keyup/click/focusin retries.
}
return
}

Expand Down