Skip to content

esp-radio: make Ssid::as_bytes public #6322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fbartho wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −1
Open

esp-radio: make Ssid::as_bytes public #6322

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c99cf58
feat(esp-radio): make Ssid::as_bytes public
fbartho Sep 12, 2026
d965e59
fix(esp-radio): mark Ssid::as_bytes unstable, document UTF-8 on as_str
fbartho Sep 17, 2026
1caed38
Merge remote-tracking branch 'upstream/main' into feat/ssid-raw-bytes
fbartho Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion esp-radio/src/wifi/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,11 @@ impl Ssid {
})
}

pub(crate) fn as_bytes(&self) -> &[u8] {
/// The SSID as raw bytes.
///
/// An SSID is at most 32 bytes and is not required to be valid UTF-8.
#[instability::unstable]
pub fn as_bytes(&self) -> &[u8] {
&self.ssid[..self.len as usize]
}

Expand All @@ -797,6 +801,9 @@ impl Ssid {
}

/// The SSID as a string slice.
///
/// An SSID is not required to be valid UTF-8; the result stops at the
/// first invalid byte. Use [`as_bytes`][Self::as_bytes] for the full bytes.
pub fn as_str(&self) -> &str {
let part = &self.ssid[..self.len as usize];
match str::from_utf8(part) {
Expand Down