Fix RX validation - #21
Open
Frostie314159 wants to merge 5 commits into
Open
Frostie314159 wants to merge 5 commits into
Frostie314159 wants to merge 5 commits into
Conversation
This is more of a stylistic change, but it does make it clearer, from where the log messages are coming.
The compiler fails to recognize, that `queue` can only be in the range of 0..=4, and emits a panic branch for the call to `unwrap`. Using a for loop instead of iterators with `for_each` fixes this.
Previously, RX validation did not work properly on the ESP32-S2, since I used absolute offsets. My testing indicates that this is fixed now.
Seems to work just fine.
These changes are adapted from #23. Co-authored-by: Matt Davis <matteius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes made in #17 did not properly work on the ESP32-S2, due to my use of absolute offsets in the header parsing. This has been fixed and tested. I also improved the log strings a little, optimized TX completion handling, and changed the [LowLevelDriver::start_rx] function to not require a pointer to the base of the list. This allows restarting RX, even if the list is empty.