Sync 5 commits from waywardgeek/sonic - #2
Open
austek wants to merge 6 commits into
Open
Conversation
Fix downSampleBuffer overflow when numChannels != 1
Allow gcc to be overridden by passed in CC
Change CC variable assignment to conditional
4 tasks
austek
added a commit
to ZirekHQ/espeak-ng-sonic
that referenced
this pull request
Aug 23, 2026
Fork-only notes for working in this repo with Claude Code: build/test commands (including where develop's build diverges from master's, pending PR espeak-ng#2), the sinc-FIR/overlap-add architecture, bug patterns already found here via ASan/UBSan, and the branch layout that keeps this kind of file out of upstream PR diffs (topic branches for upstream PRs are cut from espeak-main, never from develop).
tests.h/runtests.c already declare and call sonicTestStreamCreation, sonicTestParameters, sonicTestFlush, and sonicTestSimpleProcessing -- all defined in tests/sonic_api_test.c, which this same commit series adds to the tests/ directory -- but tests/Makefile's TEST_SRC was never updated to include it, so `cd tests && make runtests` fails to link with undefined references to all four.
austek
added a commit
to ZirekHQ/espeak-ng-sonic
that referenced
this pull request
Aug 23, 2026
tests.h/runtests.c declare and call sonicTestStreamCreation, sonicTestParameters, sonicTestFlush, and sonicTestSimpleProcessing -- all defined in tests/sonic_api_test.c -- but tests/Makefile's TEST_SRC was never updated to include it, so `cd tests && make runtests` fails to link with undefined references to all four. Same gap ported (and independently confirmed) in waywardgeek/sonic#72; also fixed directly in the still-open PR espeak-ng#2 ("Sync 5 commits from waywardgeek/sonic"), which is what actually introduces this mismatch on that branch -- this commit applies the same fix to develop directly, since develop already has that content merged in independently of whether/when espeak-ng#2 lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch was behind upstream waywardgeek/sonic by 5 commits. Fast-forward merge, no conflicts:
espeak-ng's docs/building.md points to this repo as the recommended sonic dev library (libsonic-dev), so keeping it current with upstream matters independent of the Android build, which fetches waywardgeek/sonic directly.