Add gas_delivered_gj field
#43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for parsing gas delivery measurements in GigaJoules (GJ), required for Eneco's district heating smart meters in the Netherlands. The PR also includes code refactoring to simplify numeric parsing logic and freezes the cmake_template dependency version for reproducibility.
Key changes:
- Adds new
gas_delivered_gjfield with GJ/MJ units sharing the same OBIS ID asgas_delivered - Introduces
NumParser::parse_float_or_inthelper method to reduce code duplication - Freezes cmake_template version to a specific commit hash
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/dsmr_parser/fields.h | Adds gas_delivered_gj field definition and refactors FixedField/AveragedFixedField to use new parse_float_or_int helper |
| src/dsmr_parser/parser.h | Introduces parse_float_or_int method to consolidate float/integer parsing with unit fallback logic |
| tests/parser_test.cpp | Adds test case for gas_delivered_gj field and updates unknown_error flag in two existing tests |
| CMakeLists.txt | Changes cmake_template from tracking main branch to specific commit hash for build reproducibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PolarGoose
force-pushed
the
gas_delivered_field_can_have_GJ_units_instead_of_m3
branch
from
f3dc0df to
b851744
Compare
PolarGoose
deleted the
gas_delivered_field_can_have_GJ_units_instead_of_m3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gas_deliveredfield can haveGJunits instead ofm3. #42NumParser::parse_float_or_intmethod to simplify existing codeCMakeLists.txt: freezecmake_templateversion.