Adding support for fish shell (CON-1840)#1573
Open
noranraskin wants to merge 3 commits intoespressif:mainfrom
Open
Adding support for fish shell (CON-1840)#1573noranraskin wants to merge 3 commits intoespressif:mainfrom
noranraskin wants to merge 3 commits intoespressif:mainfrom
Conversation
…dimmable light on the same endpoint)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding
export.fishwhich does the same asexport.shjust for fish-shell. The provided solution in #1206 didn't work for me as after runningbash -c "source export.shdidn't setESP_MATTER_PATHthus building didn't workRelated
Fixes #1206
Testing
Tested both
source export.fishandsource ~/esp-matter/export.fishand compiled an example afterwards successfully.Checklist
Before submitting a Pull Request, please ensure the following: