feat(registry): Add generic registry for source, not target#737
feat(registry): Add generic registry for source, not target#737rattboi wants to merge 2 commits into
Conversation
This allows auth to a generic source registry, such as dockerhub. This partially solves estahn#50
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
- Coverage 29.24% 28.60% -0.65%
==========================================
Files 11 12 +1
Lines 824 867 +43
==========================================
+ Hits 241 248 +7
- Misses 558 594 +36
Partials 25 25 ☔ View full report in Codecov by Sentry. |
|
Somehow I missed that this PR exists already: Any way we could get that one across the line? Currently running into dockerhub rate-limiting and really need to be able to auth k8s-image-swapper against docker.io |
Which one do you think makes more sense to look at? I'm trying to find some time this week. |
I'd say definitely the other one. It does everything this one does, and more, and has better tests. It seems you've reviewed the other PR previously and there was just a papercut left. If the OG author isn't receptive or has disappeared, and that's the only issue left, ping me and I'll pull their branch and make the changes so we can get this across the finish line. |
This allows auth to a generic source registry, such as dockerhub.
This partially solves #50