add tag when copying image when sourceRef is using both tag and digest#864
Open
jetersen wants to merge 1 commit into
Open
add tag when copying image when sourceRef is using both tag and digest#864jetersen wants to merge 1 commit into
jetersen wants to merge 1 commit into
Conversation
Author
|
@estahn not sure what your notification settings are so, I'll allow myself to ping you 😅 |
Author
|
Sadly not working. Not sure why it fails to tag the images. Maybe the code flow needs to be slightly different. Potentially we always want to ensure it tag images whether the sha is already uploaded or not 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #836
Not sure how to best unit test or how to add it to the e2e tests 🤔
I'll try and give the container image a spin in our staging cluster.