Skip copy for given container registry domain#865
Open
jetersen wants to merge 1 commit into
Open
Conversation
Author
|
@estahn not sure what your notification settings are so, I'll allow myself to ping you 😅 |
Author
|
Been running this in production for a while and works as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since AWS has added more options for pull through cache on ECR.
I would prefer to use that but there a still unsupported image sources. Not all registries are supported so this provides the flexibility to skip the once ECR Pull through cache handles.
There is still a benefit to k8s-image-swapper since it supports the image swap on a pod level. Cause we want use tooling to detect changes to the images we use on a higher level than the pod.
Currently ECR supports:
So far we have come across other image sources we use that are not supported by ECR pull through: