Update estravere version#313
Closed
roiDaniela wants to merge 17 commits intoestools:masterfrom
roiDaniela:master
Closed
Update estravere version#313roiDaniela wants to merge 17 commits intoestools:masterfrom roiDaniela:master
roiDaniela wants to merge 17 commits intoestools:masterfrom
roiDaniela:master
Conversation
In regard to issue #206 ("Attach comment to an empty object"): I have an initial modification of attachComments() and addComments() which supports comments in empty object/block. I've called them inline comments, and they are attached to the node which represents the empty object/block (i.e. ObjectExpression/BlockStatement).
Indentation got broken with the introduction of inline comments
Add tests to Gadi's inline comments implemetation
Add tests to inline comments
Add support for inline comments
Add tests to Gadi's inline comments implemintation
…th-single-comment.expected.js
Updated according to new traverese
Update try-block-line-comment.expected.js
Author
|
The new 2 tests failed beacause this change - estools/estraverse#72 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.