Skip to content

source-amplitude: remove date-time format from date field in average_session_length#355

Merged
Alex-Bair merged 2 commits into
masterfrom
bair/source-amplitude-remove-date-format
Apr 2, 2026
Merged

source-amplitude: remove date-time format from date field in average_session_length#355
Alex-Bair merged 2 commits into
masterfrom
bair/source-amplitude-remove-date-format

Conversation

@Alex-Bair
Copy link
Copy Markdown
Member

@Alex-Bair Alex-Bair commented Mar 26, 2026

This PR's scope includes:

  • removing the date-time format from the date field in the average_session_length stream. Values are naive datetime strings, which Flow does not recognize as a date-time format. The platform is opinionated in that regard.
  • cleaning up failing workflows leftover after importing certain connectors into the connectors repo

It turns out that the `average_session_length` stream's `date` field
doesn't fit a `date` or `date-time` format; they're naive datetime
strings like `2026-01-01T00:00:00`. Flow doesn't recognize this as a
`date-time` format since there's no timezone.
These connectors have all been imported into the connectors repository, and the ATF versions have been deprecated & are no longer published. The workflows for these deprecated connectors always fail because they (correctly!) don't have permission to overwrite the images built with the imported connector. So, we may as well clean up these workflows to save a few cents.
@Alex-Bair Alex-Bair requested a review from a team March 26, 2026 17:03
@Alex-Bair Alex-Bair changed the title source-amplitude: remove date format from date field in average_session_length source-amplitude: remove date format from date-time field in average_session_length Mar 26, 2026
@Alex-Bair Alex-Bair changed the title source-amplitude: remove date format from date-time field in average_session_length source-amplitude: remove date-time format from date field in average_session_length Mar 26, 2026
Copy link
Copy Markdown
Member

@willdonnelly willdonnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex-Bair Alex-Bair merged commit ec3caf0 into master Apr 2, 2026
45 checks passed
@Alex-Bair Alex-Bair deleted the bair/source-amplitude-remove-date-format branch April 2, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants