source-pendo: escape " and \ in filter expressions#4477
Open
Alex-Bair wants to merge 1 commit into
Open
Conversation
Some users have identifiers that contain the special character `"`, and it's suspected that not escaping `"` is causing issues with aggregation requests: ``` capture.Account.incremental: Encountered HTTP error status 400 which cannot be retried. URL: https://us1.app.pendo.io/api/v1/aggregation Response: Cannot parse filter expression ``` This commit escapes `"` and `\` when using identifiers in aggregation requests, which should fix the issue. Note: I saw this [Pendo doc](https://support.pendo.io/hc/en-us/articles/21326198721563-Choose-IDs-and-metadata) states: > Don't use \ or " or invalid UTF-8 characters in an Account ID. These characters can result in errors in Pendo. So... it's possible some other Pendo side error will occur & this won't unblock captures for users who use `\` or `"` in their account ids. If that's the case, we'll need to revisit & investigate further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Some users have identifiers in Pendo that contain the special character
", and it's suspected that not escaping"in these identifiers is causing issues with aggregation requests:This commit escapes
"and\when using identifiers in aggregation requests, which should fix the issue.Note: I saw this Pendo doc states:
So... it's possible some other Pendo side error will occur & this won't unblock captures for users who use
\or"in their account ids. If that's the case, we'll need to revisit & investigate further.Notes for reviewers:
I'm unable to reproduce the issue since we don't have a dev Pendo account, so this is based purely off of the details provided in the user's bug report. The bug makes sense & definitely seems like an issue, but I wasn't able to directly confirm that the bug is what's causing the
Cannot parse filter expressionfailure.