go/writer: add variant parquet type#4487
Draft
jacobmarble wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds
LogicalTypeVariantto thego/writerparquet package. Variant is a group of two requiredBYTE_ARRAYchildren (valueandmetadata) per the Parquet Variant spec, enabling connectors to emit JSON objects/arrays as native Variant columns instead of raw strings.New options
WithParquetSchemaObjectAsVariant()andWithParquetSchemaArrayAsVariant()let connectors opt in. AgetVariantValhelper converts common Go types tovariant.Valueat write time.Notes for reviewers:
go/writer: column-oriented parquet write buffer) has its own PR at go/writer: column-oriented parquet write buffer #4485 — please review/merge that first. This PR contains only the top commit.LogicalTypeVariantmaps to two physical parquet columns, sophysicalColumnCount()was added toParquetSchemaElementandcolumnChunkCountaccounting was updated accordingly.