doc/shape: add top-level contentMediaType to all shapes#2945
Open
mdibaiee wants to merge 2 commits into
Open
Conversation
mdibaiee
force-pushed
the
mahdi/shape-contentType
branch
4 times, most recently
from
9fe18db to
dcd70bc
Compare
jgraettinger
approved these changes
May 15, 2026
| - redact: {strategy: sha256} | ||
| - default: john.doe@gmail.com | ||
| # `contentMediaType` is now a top-level Shape field, so the | ||
| # union of `{contentMediaType: x}` with `{type: null}` drops |
Member
There was a problem hiding this comment.
nit: this behavior looks right but the comment doesn't make sense to me.
Rather, when intersecting schemas, if one schema doesn't have an opinion (doesn't set contentMediaType), we allow a Some on another schema to take effect -- but then remove it if there's disagreement.
When unioning, we require all unioned schemas have the same Some to carry it forward into the union'd Shape.
mdibaiee
force-pushed
the
mahdi/shape-contentType
branch
2 times, most recently
from
d364bf7 to
56975f0
Compare
Mechanical regeneration only; no .proto changes. Captures formatting shifts from the local prost-build/protoc toolchain (e.g. `*` -> `-` bullets in doc comments, multi-line attribute reflow, type-parameter line breaks). Splitting this from the next commit so review can focus on the functional diff.
mdibaiee
force-pushed
the
mahdi/shape-contentType
branch
from
56975f0 to
84f3e3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
content_typefor string shapes specifically (this matches JSONSchema's spec), which referred to JSONSchema'scontentMediaTypecontentMediaTypeto apply to all types, and the naming is now consistent with JSONSchema. This allows schemas such as:Which we intend to use for conveying more information about type of fields from captures to materializations (See example: estuary/connectors#4400
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)