Skip to content

Add prop.created notification for competition members#132

Merged
eswan18 merged 1 commit into
mainfrom
feature/prop-created-notification
Apr 8, 2026
Merged

Add prop.created notification for competition members#132
eswan18 merged 1 commit into
mainfrom
feature/prop-created-notification

Conversation

@eswan18
Copy link
Copy Markdown
Owner

@eswan18 eswan18 commented Apr 8, 2026

Summary

  • Publish prop.created event via Pub/Sub when a prop is added to a competition
  • Notifies all competition members (except the creator) via the comms email service
  • Includes prop text, competition name, and a link to the competition page
  • Member lookup happens outside the RLS transaction to avoid breaking existing test mocks
  • Added server-only and pubsub/client mocks to props.test.ts (all 28 existing tests pass)

The matching comms-side changes (template, handler, per-recipient rendering) are already deployed on the comms repo.

Test plan

  • All 28 existing props unit tests pass
  • Pub/Sub client tests pass (4 tests)
  • Deploy to staging and create a prop in a competition — verify members receive the email

🤖 Generated with Claude Code

Notifies all competition members (except the creator) via Pub/Sub.
Member lookup happens outside the transaction to avoid breaking
existing test mocks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@eswan18 eswan18 merged commit 00fde3f into main Apr 8, 2026
1 check passed
@eswan18 eswan18 deleted the feature/prop-created-notification branch April 8, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant