Add competition admin role support and edit button for props#133
Merged
Conversation
The prop update server action already permits competition admins via RLS, but the competition prop view only rendered the edit dialog for system admins and never exposed a button to open it. Add a visible Edit button in the prop header and broaden the isAdmin check to include users with the "admin" role in the competition.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends admin access control to include competition-level admins (in addition to global admins) and adds an edit button to the prop view for admins.
Key Changes
getCurrentUserRole()call outside the private competition check so the user's role is always retrieved and available for authorization decisionsisAdminprop to recognize both global admins (user.is_admin) and competition admins (userRole === "admin")Implementation Details
userRolevariable for reusecompetition.is_private && userRole === nullsetIsEditDialogOpenstate to trigger the edit dialoghttps://claude.ai/code/session_013LjY2hYrqzHmZi4fmYxyTz