Implement client_secret_basic (HTTP Basic Auth) for client authentication#53
Merged
Conversation
…tion The OIDC discovery document advertised client_secret_basic support but only client_secret_post (form values) was implemented. Any client using HTTP Basic Auth for client authentication would fail. authenticateClient now checks for an Authorization: Basic header first, falling back to form values. This uses Go's built-in r.BasicAuth() which handles the base64 decoding and credential splitting per RFC 7617. Closes #51 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authenticateClientnow supports bothclient_secret_post(form values) andclient_secret_basic(HTTP Basic Auth) for client authentication, matching what the OIDC discovery document advertisesr.BasicAuth()for parsing per RFC 7617Closes #51
Test plan
go build ./...andgo vet ./...passparseClientCredentials: Basic auth, form values, and precedence🤖 Generated with Claude Code